Bug 1999075: Pan the selected workload into the full view

[karthikjeeyar]

Fixes:

https://issues.redhat.com/browse/ODC-6054

Analysis / Root cause:

When the component is selected, its not completely moved to the full view in the canvas

Solution Description:

Change the minimumVisible prop to 100, so the selected component moves in the the full view.

Screen shots / Gifs for design review:

Before:

After:

Test setup:

1. Click on that Deployment & the side panel will show
2. Close the side panel, drag that Deployment all the way to the right side of the canvas
3. Click on that Deployment again & you'll see that the deployment is moved in full view
4. Now with that side panel open carefully move that deployment so that it's partially hidden by the side panel
5. Close the side panel by clicking X on it
6. Select the deployment

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

cc: @serenamarie125 @jeff-phillips-18

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 1999075, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1999075: Pan the selected workload into the full view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/kind bug
/bugzilla refresh

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 1999075, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/kind bug
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/cc @christianvogt

[christianvogt]

/lgtm

We could probably look at adding a feature to topology that would instead bring the full item into view instead of defining a fixed pixel size.

[invincibleJai]

/lgtm

added again as label didn't got added earlier

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/topology/OWNERS [andrewballantyne,christianvogt,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#9921

Bugzilla bug 1999075 has been moved to the MODIFIED state.

In response to this:

Bug 1999075: Pan the selected workload into the full view

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.