Bug 1999179: Create BuildConfig webhook secrets before creating knative resources

[rottencandy]

Fixes:
https://issues.redhat.com/browse/ODC-6211

Analysis / Root cause:
When knative resources are created, there is an early return, which prevents the rest of the resources(including the secret) from being created.

Solution Description:
Create the webhook secret before creating knative resources.

Unit test coverage report:

Test Suites: 1 passed, 1 total
Tests:       12 passed, 12 total
Snapshots:   0 total
Time:        17.026s
Ran all test suites matching /import-submit-utils/i.

Test setup:

1. Open developer perspective, Add page, Import from Git
2. Enter a git URL
3. As resources select "Serverless Deployment"
4. Create
5. Open navigation entry "Builds" and the new created "BuildConfig" (app name)

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug

[openshift-ci]

@rottencandy: This pull request references Bugzilla bug 1999179, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1999179: Create BuildConfig webhook secrets before creating knative resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rottencandy]

/cc @jerolimov

[rottencandy]

/cc @invincibleJai

[invincibleJai]

/lgtm
/approve

verified the changes, works as expectedd

[rottencandy]

/bugzilla refresh

[openshift-ci]

@rottencandy: This pull request references Bugzilla bug 1999179, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rottencandy]

/cherrypick release-4.8

[openshift-cherrypick-robot]

@rottencandy: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rottencandy: All pull requests linked via external trackers have merged:

• openshift/console#9924

Bugzilla bug 1999179 has been moved to the MODIFIED state.

In response to this:

Bug 1999179: Create BuildConfig webhook secrets before creating knative resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@rottencandy: #9924 failed to apply on top of branch "release-4.8":

Applying: create webhook secrets before knative resources
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils.spec.ts
M	frontend/packages/dev-console/src/components/import/import-submit-utils.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/import/import-submit-utils.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/import/import-submit-utils.ts
Auto-merging frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils.spec.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/import/__tests__/import-submit-utils.spec.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 create webhook secrets before knative resources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.