Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose list, table, ResourceLink componens and useK8sModel(s) hooks via plugin SDK #9925

Merged
merged 1 commit into from Sep 2, 2021
Merged

Expose list, table, ResourceLink componens and useK8sModel(s) hooks via plugin SDK #9925

merged 1 commit into from Sep 2, 2021

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Aug 30, 2021 •
edited

No description provided.

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 30, 2021
@rawagner rawagner force-pushed the expose_list_table branch 5 times, most recently from 95fd23a to 9361858 Compare September 1, 2021 10:59
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
@rawagner rawagner changed the title [WIP] Expose list and table components via plugin SDK [WIP] Expose list, table, ResourceLink componens and useK8sModel(s) hooks via plugin SDK Sep 1, 2021
@rawagner rawagner changed the title [WIP] Expose list, table, ResourceLink componens and useK8sModel(s) hooks via plugin SDK Expose list, table, ResourceLink componens and useK8sModel(s) hooks via plugin SDK Sep 1, 2021
@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 1, 2021
vojtechszocs
vojtechszocs suggested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@vojtechszocs vojtechszocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a small nit: in frontend/public/* sources, I'd suggest putting @console/dynamic-plugin-sdk imports above the relative path imports (seems like the import sort ESLint rule is not applied to @console/internal package sources).

frontend/public/components/factory/ListPage/ListPageFilter.tsx
@@ -40,7 +24,6 @@ const ListPageFilter: React.FC<ListPageFilterProps> = ({
nameFilterPlaceholder={nameFilterPlaceholder}
labelFilterPlaceholder={labelFilterPlaceholder}
onFilterChange={onFilterChange}
textFilter={textFilter}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this prop passthrough anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in the future, but in other form.

textFilter is a string name of some function in https://github.com/openshift/console/blob/master/frontend/public/components/factory/table-filters.ts#L39

which is very dangerous.

If in the future we will need to provide custom implementation of text filter a consumer will be able to pass a new optional property as a function, not string. The optional property wont break the API

So we are good for now.

@rawagner
Copy link
Contributor Author

rawagner commented Sep 2, 2021

/label px-approved
/label docs-approved

There are no user visible changes, and we have approval for dynamic plugin APIs.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 2, 2021
@rawagner
Copy link
Contributor Author

rawagner commented Sep 2, 2021

/retest

@yapei
Copy link
Contributor

yapei commented Sep 2, 2021 •
edited

tested the PR on a cluster created by cluster-bot, accessing Demo Plguin -> List page returns pods list page, the filtering works as well as the 'Create Pod' functionality.
Screen Shot 2021-09-02 at 9 13 47 PM

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 2, 2021
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6744c15 into openshift:master Sep 2, 2021
@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs requested changes

@afreen23 afreen23 Awaiting requested review from afreen23

@andybraren andybraren Awaiting requested review from andybraren

Assignees

@vojtechszocs vojtechszocs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rawagner @yapei @vojtechszocs @spadgett @openshift-merge-robot