Bug 1996159: Show 404 page only after all dynamic plugins are processed

[vojtechszocs]

This PR fixes a race condition in a scenario where a user navigates directly to a plugin-contributed route and Console shows 404 error page until the relevant plugin finishes loading, then re-renders the plugin-contributed page content as expected.

The expected behavior is to wait until all dynamic plugins are processed (i.e. either loaded or failed) before falling back to the 404 error page.

[openshift-ci]

@vojtechszocs: This pull request references Bugzilla bug 1996159, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1996159: Show 404 page only after all dynamic plugins are processed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

/bugzilla refresh

[openshift-ci]

@vojtechszocs: This pull request references Bugzilla bug 1996159, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

/label px-approved
/label docs-approved

There are no user visible changes, and we have approval for dynamic plugin APIs.

[christianvogt]

looks good

[spadgett]

/lgtm

Let's go with this PR in favor of #9559 since it contains both commits. Since this is a bug fix, we don't need qe approval prior to merging.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@vojtechszocs: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 1996159 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1996159: Show 404 page only after all dynamic plugins are processed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@vojtechszocs: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/console#9559 is closed

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1996159 has not been moved to the MODIFIED state.

In response to this:

Bug 1996159: Show 404 page only after all dynamic plugins are processed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.