New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1999266: Fix click issue with topology context menu #9930
Bug 1999266: Fix click issue with topology context menu #9930
Conversation
@rohitkrai03: This pull request references Bugzilla bug 1999266, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c5c0cf8
to
8e9b37a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
verified locally, works as expected
/hold waiting for analyze to pass |
8e9b37a
to
914963a
Compare
/lgtm |
914963a
to
52872c8
Compare
52872c8
to
d6022b5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rohitkrai03: All pull requests linked via external trackers have merged: Bugzilla bug 1999266 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-6212
Analysis / Root cause: We were rendering
MenuItem
insideContextMenuItem
from PF Topology which is actuallyDropdownItem
. So it was essentially renderingMenuItem
insideDropdownItem
which is why the clickable area shrinks down to just the text and not the whole action item.Solution Description: Render
ContextMenuItem
directly instead ofMenuItem
when using in topology context menu..Screen shots / Gifs for design review:
Screen.Recording.2021-08-30.at.11.59.18.PM.mov
Browser conformance: