Bug 1999669: Add a wrapper around AddCapacityModal to inject StorageCluster #9938
Conversation
bipuladh
commented
Aug 31, 2021
•
bipuladh
commented
openshift-ci
bot
added
component/ceph
bipuladh
force-pushed
the
fix-add-storage
branch
from
4edd5f8
to
5bcb6b1
Compare
bipuladh
changed the title
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@bipuladh: This pull request references Bugzilla bug 1999669, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@bipuladh: This pull request references Bugzilla bug 1999669, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I think you need to run diff --git a/frontend/packages/ceph-storage-plugin/locales/en/ceph-storage-plugin.json b/frontend/packages/ceph-storage-plugin/locales/en/ceph-storage-plugin.json
index 83962a0e73..0b47eede54 100644
--- a/frontend/packages/ceph-storage-plugin/locales/en/ceph-storage-plugin.json
+++ b/frontend/packages/ceph-storage-plugin/locales/en/ceph-storage-plugin.json
@@ -62,6 +62,7 @@
"{{storeType}} represents a storage target to be used as the underlying storage for the data in Multicloud Object Gateway buckets.": "{{storeType}} represents a storage target to be used as the underlying storage for the data in Multicloud Object Gateway buckets.",
"Cancel ": "Cancel ",
"Save": "Save",
+ "Edit Bucket Class Resources": "Edit Bucket Class Resources",
"What is a BackingStore?": "What is a BackingStore?",
"BackingStore represents a storage target to be used as the underlying storage for the data in Multicloud Object Gateway buckets.": "BackingStore represents a storage target to be used as the underlying storage for the data in Multicloud Object Gateway buckets.",
"Multiple types of BackingStores are supported: asws-s3 s3-compatible google-cloud-storage azure-blob obc PVC.": "Multiple types of BackingStores are supported: asws-s3 s3-compatible google-cloud-storage azure-blob obc PVC.",
@@ -672,7 +673,6 @@
"Selected nodes are based on the StorageClass <1>{{scName}}</1> and fulfill the stretch cluster requirements with a recommended requirement of 14 CPU and 34 GiB RAM per node.": "Selected nodes are based on the StorageClass <1>{{scName}}</1> and fulfill the stretch cluster requirements with a recommended requirement of 14 CPU and 34 GiB RAM per node.",
"Storage": "Storage",
"Disks": "Disks",
- "Edit Bucket Class Resources": "Edit Bucket Class Resources",
"Backing Store": "Backing Store",
"Bucket Class": "Bucket Class",
"Namespace Store": "Namespace Store", |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
bipuladh
force-pushed
the
fix-add-storage
branch
from
5bcb6b1
to
2ab45cf
Compare
openshift-ci
bot
added
kind/i18n
|
/lgtm |
|
/test ceph-storage-plugin |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
openshift-ci
bot
added
the
needs-rebase
Add a wrapper around AddCapacityModal to inject StorageCluster Add missing actions for various resources
bipuladh
force-pushed
the
fix-add-storage
branch
from
2ab45cf
to
b74d921
Compare
openshift-ci
bot
removed
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, rexagod, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@bipuladh: All pull requests linked via external trackers have merged: Bugzilla bug 1999669 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
