Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1999422: Guard display of supported vendors #9942

Merged

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented Aug 31, 2021

  • external vendors must be flagged based on the annotation vendors.odf.openshift.io/kind
  • this will control the disablement of vendor's UI in ODF UI (in case the vendor could not finish up in a proposed release)

Followup Pr for UI for red-hat-storage/odf-operator#74

Signed-off-by: Afreen Rahman afrahman@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@afreen23: An error was encountered adding this pull request to the external tracker bugs for bug 1999422 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 503 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1999422: Guard display of supported vendors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@afreen23: This pull request references Bugzilla bug 1999422, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1999422: Guard display of supported vendors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2021
Afreen Rahman added 2 commits September 1, 2021 05:19
- external vendors must be flagged based on the annotation `vendors.odf.openshift.io/kind`
- this will control the disablement of vendor's UI in ODF UI (in case the vendor could not finish up in a proposed release)

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
 - vendors.odf.openshift.io/kind is required for displaying the external vendor in ODF UI

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@SanjalKatiyar
Copy link
Contributor

/lgtm
If annotation is not present, external vendor option will not be shown in Connect an external storage platform > Storage platform dropdown

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@afreen23
Copy link
Contributor Author

afreen23 commented Sep 1, 2021

/lgtm
If annotation is not present, external vendor option will not be shown in Connect an external storage platform > Storage platform dropdown

Yes, thats expected.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@afreen23
Copy link
Contributor Author

afreen23 commented Sep 1, 2021

/retest

@afreen23
Copy link
Contributor Author

afreen23 commented Sep 1, 2021

/test ceph-storage-plugin

@afreen23
Copy link
Contributor Author

afreen23 commented Sep 2, 2021

/test e2e-gcp-console

@afreen23
Copy link
Contributor Author

afreen23 commented Sep 2, 2021

/test ceph-storage-plugin

@openshift-merge-robot openshift-merge-robot merged commit 84a7a2f into openshift:master Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1999422 has been moved to the MODIFIED state.

In response to this:

Bug 1999422: Guard display of supported vendors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants