New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1999615: Use target closest method only when available #9944
Bug 1999615: Use target closest method only when available #9944
Conversation
@rottencandy: This pull request references Bugzilla bug 1999615, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rottencandy: This pull request references Bugzilla bug 1999615, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this works as the goal of the call is to check for an internal item. If it for instance was needed and somehow was not available -- the modal would just close on favourite. Low risk, mild annoyance, but not likely to happen either way.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, divyanshiGupta, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@rottencandy: All pull requests linked via external trackers have merged: Bugzilla bug 1999615 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6295
Analysis / Root cause:
The event target is always assumed to be an
HTMLElement
, but since the listener is forwindow
, the target can also beHTMLDocument
(which does not have theclosest()
method). This causes the page to crash.Solution Description:
Use the
closest()
method only when available.Screen shots / Gifs for design review:
0.mp4
Unit test coverage report:
(Unchanged)
Browser conformance:
/kind bug