Bug 2000499: dismiss toast if export cr gives 404

[invincibleJai]

Fixes:
https://issues.redhat.com/browse/ODC-6286

Analysis / Root cause:

1. if export app toast is not cleared by the user (i.e user doesn't click on download or close) and a new one is triggered then the old toast still shows and the download link gives 404.
2. If export app toast is shown and the user deletes export CR manually then toast still shows and the download link gives 404.

Solution Description:

1. once a new export trigger happens then the old toast should be auto removed if exists.
2. If user deletes export CR then associated toast should get dismissed

Screen shots / Gifs for design review:

1. once a new export trigger happens then the old toast should be auto removed if exists.

2. If the user deletes export CR then associated toast should get dismissed

Test setup:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2000499, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2000499: dismiss toast if export cr gives 404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/king bug

[invincibleJai]

/hold

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2000499, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2000499: dismiss toast if export cr gives 404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 2000499, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2000499: dismiss toast if export cr gives 404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/unhold

[christianvogt]

If i start a new export, the toast disappears immediately.
However if I manually delete the export CR, the toast still lingers around for some time.

[invincibleJai]

If i start a new export, the toast disappears immediately.
However if I manually delete the export CR, the toast still lingers around for some time.

yeah for restart the export app, am doing the cleanup and in this case watchresources get the update quick but for another scenario i.e deletion of export CR watchresources for some reason takes a bit to update with 404 hence takes a couple of seconds and eventually toast gets auto dismissed.

we can look at this later.

[sahil143]

/lgtm

verified locally, works as expected overall however in one scenario if user manually deletes export CR then toast dismiss takes a while

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@invincibleJai: All pull requests linked via external trackers have merged:

• openshift/console#9961

Bugzilla bug 2000499 has been moved to the MODIFIED state.

In response to this:

Bug 2000499: dismiss toast if export cr gives 404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.