Bug 1988905: External mode deployments fails on parsing json in ODF wizard #9966

afreen23 · 2021-09-02T01:37:12Z

fixed the failure in parsing json
updated review page to show only details relevant to external RHCS mode
updated error handling since the errors were uncaught
disabled rhcs mode on non supported infra

Signed-off-by: Afreen Rahman afrahman@redhat.com

openshift-ci · 2021-09-02T01:37:21Z

@afreen23: This pull request references Bugzilla bug 1988905, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1988905: External mode deployments fails on parsing json in ODF wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2021-09-02T01:38:08Z

...ate-storage-system/create-storage-system-steps/backing-storage-step/backing-storage-step.tsx

+  const allowedExternalStorage: ExternalStorage[] =
+    !enableRhcs || hasOCS
+      ? SUPPORTED_EXTERNAL_STORAGE.filter(
+          ({ model }) => getStorageSystemKind(model) !== STORAGE_CLUSTER_SYSTEM_KIND,
+        )
+      : SUPPORTED_EXTERNAL_STORAGE;


dont show RHCS is one is created and platform is invalid.
This is legacy, we missed it.

SanjalKatiyar · 2021-09-02T03:53:15Z

...ate-storage-system/create-storage-system-steps/backing-storage-step/backing-storage-step.tsx

@@ -23,6 +23,8 @@ import { NO_PROVISIONER } from '../../../../constants';
 import './backing-storage-step.scss';
 import { GUARDED_FEATURES } from '../../../../features';

+const RHCS_SUPPORTED_INFRA = ['BareMetal', 'None', 'VSphere', 'OpenStack', 'oVirt', 'IBMCloud'];


We can add this to constants file.

Its just used here. lets keep it.

SanjalKatiyar · 2021-09-02T03:56:05Z

...storage-system/create-storage-system-steps/review-and-create-step/review-and-create-step.tsx

    nodes,
  } = state;
  const { capacity, arbiterLocation, enableArbiter } = capacityAndNodes;
  const { encryption, kms, networkType } = securityAndNetwork;
  const { deployment, externalStorage, type } = backingStorage;

  const isMCG = deployment === DeploymentType.MCG;
+  const isRhcs = !_.isEmpty(connectionDetails);
+  const isStandaloneExternal = hasOCS && !_.isEmpty(createStorageClass);


One doubt... we also have already set flags to check whether it is external cluster or not, will that not work here ??

If independent mode is true then we can say its rhcs but if its false we cannot say -

a non rhcs cluster created or

a non rhcs cluster not present

Also in future we will have many storage systems, so keeping this way, would not complicate

SanjalKatiyar · 2021-09-02T13:56:59Z

...-plugin/src/components/create-storage-system/external-storage/red-hat-ceph-storage/index.tsx

-        validated={formState.isRejected ? 'error' : 'default'}
-      />
-    </FormGroup>
+    <ErrorHandler error={podsLoadError || csvLoadError} loaded={podsLoaded || csvLoaded}>


Suggested change

<ErrorHandler error={podsLoadError || csvLoadError} loaded={podsLoaded || csvLoaded}>

<ErrorHandler error={podsLoadError || csvLoadError} loaded={podsLoaded && csvLoaded}>

SanjalKatiyar · 2021-09-02T13:58:36Z

...-plugin/src/components/create-storage-system/external-storage/red-hat-ceph-storage/index.tsx

+                  download="ceph-external-cluster-details-exporter.py"
+                  target="_blank"
+                  rel="noopener noreferrer"
+                  className=""


Suggested change

className=""

nits

…wizard - fixed the failure in parsing json - updated review page to show only details relevant to external mode - updated error handling since the errors were uncaught - disabled rhcs mode on non supported infra Signed-off-by: Afreen Rahman <afrahman@redhat.com>

SanjalKatiyar

/lgtm

openshift-ci · 2021-09-02T14:38:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-09-02T21:10:36Z

@afreen23: All pull requests linked via external trackers have merged:

openshift/console#9966

Bugzilla bug 1988905 has been moved to the MODIFIED state.

In response to this:

Bug 1988905: External mode deployments fails on parsing json in ODF wizard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 2, 2021

openshift-ci bot requested review from bipuladh and cloudbehl September 2, 2021 01:37

openshift-ci bot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2021

afreen23 commented Sep 2, 2021

View reviewed changes

SanjalKatiyar reviewed Sep 2, 2021

View reviewed changes

afreen23 force-pushed the external-mode-parse branch from d035607 to 55613ec Compare September 2, 2021 10:37

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 2, 2021

afreen23 requested a review from SanjalKatiyar September 2, 2021 10:43

SanjalKatiyar reviewed Sep 2, 2021

View reviewed changes

afreen23 force-pushed the external-mode-parse branch from 55613ec to 8d7195c Compare September 2, 2021 14:20

afreen23 requested a review from SanjalKatiyar September 2, 2021 14:20

SanjalKatiyar approved these changes Sep 2, 2021

View reviewed changes

openshift-ci bot assigned SanjalKatiyar Sep 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021

openshift-merge-robot merged commit 1b407bd into openshift:master Sep 2, 2021

spadgett added this to the v4.9 milestone Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1988905: External mode deployments fails on parsing json in ODF wizard #9966

Bug 1988905: External mode deployments fails on parsing json in ODF wizard #9966

afreen23 commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

afreen23 Sep 2, 2021

SanjalKatiyar Sep 2, 2021

afreen23 Sep 2, 2021 •

edited

SanjalKatiyar Sep 2, 2021

afreen23 Sep 2, 2021

SanjalKatiyar Sep 2, 2021

SanjalKatiyar Sep 2, 2021

SanjalKatiyar left a comment

openshift-ci bot commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

	<ErrorHandler error={podsLoadError \|\| csvLoadError} loaded={podsLoaded \|\| csvLoaded}>
	<ErrorHandler error={podsLoadError \|\| csvLoadError} loaded={podsLoaded && csvLoaded}>

Bug 1988905: External mode deployments fails on parsing json in ODF wizard #9966

Bug 1988905: External mode deployments fails on parsing json in ODF wizard #9966

Conversation

afreen23 commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

afreen23 Sep 2, 2021

Choose a reason for hiding this comment

SanjalKatiyar Sep 2, 2021

Choose a reason for hiding this comment

afreen23 Sep 2, 2021 • edited

Choose a reason for hiding this comment

SanjalKatiyar Sep 2, 2021

Choose a reason for hiding this comment

afreen23 Sep 2, 2021

Choose a reason for hiding this comment

SanjalKatiyar Sep 2, 2021

Choose a reason for hiding this comment

SanjalKatiyar Sep 2, 2021

Choose a reason for hiding this comment

SanjalKatiyar left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

afreen23 Sep 2, 2021 •

edited