Bug 2000473: Monitoring dashboards: Fix clearing variables when changing dashboard #9969
Conversation
The value of variables (filter dropdowns) was being persisted as URL GET parameters when you changed from one dashboard to another. Not only should the value not be persisted, but if the value is an invalid option for the new dashboard, it could result in no data being displayed. Also removed the `MonitoringDashboardsClearVariables` Redux action both because it's unused and because it doesn't take a perspective parameter and will therefore fail.
openshift-ci
bot
added
bugzilla/severity-medium
|
@kyoto: This pull request references Bugzilla bug 2000473, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/core
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kyoto: All pull requests linked via external trackers have merged: Bugzilla bug 2000473 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The value of variables (filter dropdowns) was being persisted as URL GET
parameters when you changed from one dashboard to another. Not only
should the value not be persisted, but if the value is an invalid option
for the new dashboard, it could result in no data being displayed.
Also removed the
MonitoringDashboardsClearVariablesRedux action bothbecause it's unused and because it doesn't take a perspective parameter
and will therefore fail.
Issue was introduced by #9545