Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created separate helm release spec for CI purpose #9972

Merged
merged 2 commits into from Sep 3, 2021
Merged

Created separate helm release spec for CI purpose #9972

merged 2 commits into from Sep 3, 2021

Conversation

makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Sep 2, 2021

Description:
Helm specs are taking 13 min of time to execute all scripts, To reduce the amount of time, moved all the important helm scenarios to single spec

Jira Id: https://issues.redhat.com/browse/ODC-6327

Refactoring criteria for approving Automation PR:

Execution Commands:
Example:

    export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
    BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
    BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.8-042801.devcluster.openshift.com
    export BRIDGE_KUBEADMIN_PASSWORD
    export BRIDGE_BASE_ADDRESS
    oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
    oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
    oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
    ./test-cypress.sh -p helm -h true

Screen shots:
9972-chrome

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@makambalaji
Copy link
Contributor Author

Executed on both electron and chrome browser
image

@makambalaji
Copy link
Contributor Author

/assign @rohitkrai03

@makambalaji makambalaji changed the title Created separate helm release spec for CI purpose [WIP] Created separate helm release spec for CI purpose Sep 2, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2021
@makambalaji
Copy link
Contributor Author

To resolve the flakiness issues, needs to delete the user-settings config map, will include within this pr. so marking the PR as WIP

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Sep 2, 2021
@makambalaji makambalaji changed the title [WIP] Created separate helm release spec for CI purpose Created separate helm release spec for CI purpose Sep 2, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2021
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohitkrai03
Copy link
Contributor

@makambalaji You'll need a valid bugzilla ticket for this to get merged.

@makambalaji
Copy link
Contributor Author

@makambalaji You'll need a valid bugzilla ticket for this to get merged.

we can add the labels as well right, px-approved, docs-approved, qe-approved

@makambalaji
Copy link
Contributor Author

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit e3b7136 into openshift:master Sep 3, 2021
@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/helm Related to helm-plugin docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants