Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2000590: Warning on topology context menu right click #9975

Merged
merged 1 commit into from Sep 3, 2021
Merged

Bug 2000590: Warning on topology context menu right click #9975

merged 1 commit into from Sep 3, 2021

Conversation

yozaam
Copy link
Contributor

@yozaam yozaam commented Sep 2, 2021

Fixes:

https://issues.redhat.com/browse/ODC-6105

Analysis / Root cause:

  • ref was getting added to KebabItem function component

Solution Description:

  • wrapped the function component with a React Fragment <> </>

Screen shots / Gifs for design review:

No warning is seen anymore
image

Unit test coverage report:

Test setup:

Open topology.
Right click on any workload.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@yozaam: This pull request references Bugzilla bug 2000590, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2000590: Warning on topology context menu right click

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yozaam
Copy link
Contributor Author

yozaam commented Sep 2, 2021

/cc @rottencandy

@openshift-ci openshift-ci bot added the component/topology Related to topology label Sep 2, 2021
rottencandy
rottencandy approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@yozaam
Copy link
Contributor Author

yozaam commented Sep 3, 2021

/assign @rohitkrai03
requesting approval

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
rohitkrai03
rohitkrai03 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, rottencandy, yozaam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@yozaam
Copy link
Contributor Author

yozaam commented Sep 3, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6b655b0 into openshift:master Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@yozaam: All pull requests linked via external trackers have merged:

Bugzilla bug 2000590 has been moved to the MODIFIED state.

In response to this:

Bug 2000590: Warning on topology context menu right click

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@rottencandy rottencandy rottencandy approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@rohitkrai03 rohitkrai03

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yozaam @rohitkrai03 @rottencandy @spadgett @openshift-merge-robot