Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2000873: override list style for toast #9986

Merged
merged 1 commit into from Sep 3, 2021
Merged

Bug 2000873: override list style for toast #9986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/packages/console-shared/src/components/toast/ToastProvider.scss
View file
Open in desktop
@@ -0,0 +1,5 @@
.ocs-toast-provider {
&.pf-m-toast {
list-style: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @sg00dwin has a general fix for list styles in console. We should go ahead with this fix for now, but we might be able to remove this style after @sg00dwin's fix lands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thanks, i'll check with him and update once we have generic fix.

}
}
4 changes: 3 additions & 1 deletion frontend/packages/console-shared/src/components/toast/ToastProvider.tsx
View file
Open in desktop
Expand Up @@ -2,6 +2,8 @@ import * as React from 'react';
import { Alert, AlertGroup, AlertActionCloseButton, AlertActionLink } from '@patternfly/react-core';
import ToastContext, { ToastOptions, ToastContextType } from './ToastContext';

import './ToastProvider.scss';

const ToastProvider: React.FC = ({ children }) => {
const [toasts, setToasts] = React.useState<ToastOptions[]>([]);

Expand Down Expand Up @@ -49,7 +51,7 @@ const ToastProvider: React.FC = ({ children }) => {
<ToastContext.Provider value={controller}>
{children}
{toasts.length ? (
<AlertGroup appendTo={() => document.body} isToast>
<AlertGroup appendTo={() => document.body} isToast className="ocs-toast-provider">
{toasts.map((toast) => (
<Alert
key={toast.id}
Expand Down