Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gherkin scripts to include language preference #9988

Merged

Conversation

nemesis09
Copy link
Contributor

Epic:
https://issues.redhat.com/browse/ODC-5227

Story:
https://issues.redhat.com/browse/ODC-6329

Description:
Update gherkin scripts to include language preference and default selected "General" tab in User Preferences page

@nemesis09
Copy link
Contributor Author

/assign @sanketpathak

@@ -11,6 +11,7 @@ Feature: Manage user preferences
Scenario: Setting Developer preference for perspective: UP-01-TC01
Given user is at admin perspective
When user clicks on user dropdown on masthead and selects "User Preference"
And user sees "General" tab selected on User Preferences page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can not be part of When statements, add it in Then statements

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just remove it from here as it does not seem to be appropriate for the Then statements

@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@makambalaji
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, nemesis09, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@sanketpathak
Copy link
Contributor

Adding below labels for merging pr, This pr doesn't have any effect on dev code or docs

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 25f4d93 into openshift:master Sep 3, 2021
@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants