Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2001288: Kubevirt, use currect API when checking healthz #9993

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Sep 5, 2021

Kubevirt overview healthz by api is wrong when CNVv2.6.z is installed.

Screesnhost:

When using CNVv2.6.z with OCPv4.8.z virtualization healthz use wrong API version:
screenshot-localhost_9000-2021 09 05-10_50_36

Before:
screenshot-localhost_9000-2021 09 05-10_57_51

After:
screenshot-localhost_9000-2021 09 05-10_50_09

@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2021
@yaacov yaacov changed the title Kubevirt, use currect API when checking healthz Bug 2001288: Kubevirt, use currect API when checking healthz Sep 5, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2021

@yaacov: This pull request references Bugzilla bug 2001288, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2001288: Kubevirt, use currect API when checking healthz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2021

@yaacov: This pull request references Bugzilla bug 2001288, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang September 5, 2021 08:19
@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

/retest

@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

@metalice @glekner @avivtur @pcbailey please review

@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

/retest

@avivtur
Copy link
Contributor

avivtur commented Sep 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Sep 5, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 413049a into openshift:master Sep 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2021

@yaacov: All pull requests linked via external trackers have merged:

Bugzilla bug 2001288 has been moved to the MODIFIED state.

In response to this:

Bug 2001288: Kubevirt, use currect API when checking healthz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants