Upgrade to v0.8.5 tag #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
bump containernetworking/cni to v0.7.1
This change introduces new capability flag to change MAC address and to specify IP addresses by tuning and static.
Go mod update
name configuration.
Make host-side veth name configurable.
Support ips capability in static and mac capability in tuning
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
…iven ID Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
update go to the lastest version v1.12.7 Co-authored-by: Gabe Rosenhouse <grosenhouse@pivotal.io>
on Linux 4.4 the syscall error message is "invalid argument" not "file exists" Co-authored-by: Gabe Rosenhouse <grosenhouse@pivotal.io>
pkg/ip unit test: be agnostic of Linux version
update Go version in Vagrantfile
* Increase entroy from 2 bytes to 7 bytes to prevent collisions * Extract common library function for hash with prefix * Refactor portmap plugin to use library function fixes #347 Co-authored-by: Cameron Moreau <cmoreau@pivotal.io> Co-authored-by: Mikael Manukyan <mmanukyan@pivotal.io>
Increase IfbDeviceName size and refactor hashing functions, fix
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
host-local support idempotent allocation
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
Adds a bool to the cni config that will add a policy that allows for loopbackDSR on an interface. Updates relevant documentation. Allows L2Tunnel networks to be used for L2Bridge plugin.
Add Bruce Ma and Piotr Skarmuk as owners
Use a Describe container for the It code block of the portmap port forward integration test. Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
It turns out that the portmap plugin is not idempotent if its executed in parallel. The errors are caused due to a race of different instantiations deleting the chains. This patch does that the portmap plugin doesn't fail if the errors are because the chain doesn't exist on teardown. Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
Add the following idempotent functions to iptables utils: DeleteRule: idempotently delete an iptables rule DeleteChain: idempotently delete an iptables chain ClearChain: idempotently flush an iptables chain Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
bump the go-iptables module to v0.4.5 to avoid concurrency issues with the portmap plugin and errors related to iptables not able to hold the lock. Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
Signed-off-by: Daniel Weibel <danielmweibel@gmail.com>
Portmap doesn't fail if chain doesn't exist
Signed-off-by: Dominic Yin <yindongchao@inspur.com>
bridge: add missing cniVersion in README example
add support for mips64le
If the Linux kernel is not built with the parameter CONFIG_BRIDGE_VLAN_FILTERING, passing vlanFiltering in the Bridge struct returns an error creating the bridge interface. This happens even when no parameter is set on Vlan in the CNI config. This change fixes the case where no Vlan parameter is configured on CNI config file so the flag doesn't need to be included in the struct. Signed-off-by: Carlos de Paula <me@carlosedp.com>
Sysctl names can use dots or slashes as separator: - if dots are used, dots and slashes are interchanged. - if slashes are used, slashes and dots are left intact. Separator in use is determined by firt ocurrence. Reference: http://man7.org/linux/man-pages/man5/sysctl.d.5.html Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
DEL can be called multiple times, a plugin should return no error if the device is already removed, and other errors should be returned. It was the opposite for vlan plugin. This PR fixes it. Signed-off-by: Quan Tian <qtian@vmware.com>
Fix for the case where kernel doesn't have CONFIG_BRIDGE_VLAN_FILTERING
Improve support of sysctl name separators
Fix vlan plugin returning error when device is already removed
cni plugins version v0.8.5
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.