Bug 1897431: Upstream sync sept 2021 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have a function to run all tests in the package, in netconf_suite_windows_test.go Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This change makes ipvlan master parameter optional. Default to default route interface as macvlan does. Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
Remove extraneous test file in Windows plugin
This change allows providing an 'ipam' section as part of the
input network configuration for flannel. It is then used as
basis to construct the ipam parameters provided to the delegate.
All parameters from the input ipam are preserved except:
* 'subnet' which is set to the flannel host subnet
* 'routes' which is complemented by a route to the flannel
network.
One use case of this feature is to allow adding back the routes
to the cluster services and/or to the hosts (HostPort) when
using isDefaultGateway=false. In that case, the bridge plugin
does not install a default route and, as a result, only pod-to-pod
connectivity would be available.
Example:
{
"name": "cbr0",
"cniVersion": "0.3.1",
"type": "flannel",
"ipam": {
"routes": [
{
"dst": "192.168.242.0/24"
},
{
"dst": "10.96.0.0/12"
}
],
"unknown-param": "value"
},
"delegate": {
"hairpinMode": true,
"isDefaultGateway": false
}
...
}
This results in the following 'ipam' being provided to the delegate:
{
"routes" : [
{
"dst": "192.168.242.0/24"
},
{
"dst": "10.96.0.0/12"
},
{
"dst" : "10.1.0.0/16"
}
],
"subnet" : "10.1.17.0/24",
"type" : "host-local"
"unknown-param": "value"
}
where "10.1.0.0/16" is the flannel network and "10.1.17.0/24" is
the host flannel subnet.
Note that this also allows setting a different ipam 'type' than
"host-local".
Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
VRF support was introduced in ubuntu bionic, while it's missing in Xenial. This also introduces a change in the behaviour of nc command. On one hand, it requires a new line to send the buffer on the other side, on the other it hangs waiting for new input. To address this, a timeout was introduced to avoid the tests to hang, plus the buffer sent is terminated with a new line character. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
nc behaviour depends on the implementation version of what's on the current host. Here we use our own client with stable behaviour. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
ipvlan: make master config as optional
flannel: allow input ipam parameters as basis for delegate
This makes the behaviour more consistent across platforms. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Signed-off-by: Casey Callendrello <cdc@redhat.com>
Travis: run tests on arm64
Bump up ubuntu CI ubuntu version to bionic
This plugin allows to create a VRF with the given name (or use the existing
one if any) in the target namespace, and to allocate the interface
to it.
VRFs make it possible to use multiple routing tables on the same namespace and
allows isolation among interfaces within the same namespace. On top of that, this
allow different interfaces to have overlapping CIDRs (or even addresses).
This is only useful in addition to other plugins.
The configuration is pretty simple and looks like:
{
"type": "vrf",
"vrfname": "blue"
}
Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Latest version allows to set a VRF device as master and not only a bridge one. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Introduce a new VRF CNI meta plugin (also bump netlink package to v1.1.0)
The new tests expand coverage, checking deletion, ip address handling, 0.4.0 compatibility, behaviour in case of multiple vrfs. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
VRF CNI: Additional tests
When specified from the user, the VRF will get assigned to the given tableid instead of having the CNI to choose for a free one. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The e2e tests already covers both versions, and since the plugin is meant to be used in chains, this will augment the scope of the plugins it can be used with. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The current cni config has an extra comma and cannot be parsed normally, the kubelet will report an error as follows: "Error loading CNI config file: error parsing configuration: invalid character '}' looking for beginning of object key string" Signed-off-by: xieyanker <xjsisnice@gmail.com>
dhcp: fix example configuration
VRF: extend supported version to 0.3.1 too
VRF CNI: Add an optional table parameter.
Signed-off-by: Antonio Ojea <aojea@redhat.com>
Removing content and pointing at the new website as a part of the CNI Documentation migration. Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
conntrack does not have any way to track UDP connections, so it relies on timers to delete a connection. The problem is that UDP is connectionless, so a client will keep sending traffic despite the server has gone, thus renewing the conntrack entries. Pods that use portmaps to expose UDP services need to flush the existing conntrack entries on the port exposed when they are created, otherwise conntrack will keep sending the traffic to the previous IP until the connection age (the client stops sending traffic) Signed-off-by: Antonio Ojea <aojea@redhat.com>
Delete stale UDP conntrack entries when adding new Portmaps to containers
Signed-off-by: Casey Callendrello <cdc@redhat.com>
Signed-off-by: Casey Callendrello <cdc@redhat.com>
Instead of checking the total number of addresses, which might vary depending on the IPv6 Privacy Address settings of the distro being used, just check that we have the number of non-link-local addresses we expect. Signed-off-by: Dan Williams <dcbw@redhat.com>
With this patch, when the IPs are provisioned via CNI args or via `RuntimeConfig` the CIDR is only parsed once. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Casey Callendrello <cdc@redhat.com>
…pped Signed-off-by: Casey Callendrello <cdc@redhat.com>
plugins: fix bug where support for CNI version 0.4.0 or 1.0.0 was dropped
…cidr Fix confusing error msg invalid cidr
openshift-ci
bot
added
the
bugzilla/severity-high
|
@dougbtv: This pull request references Bugzilla bug 1897431, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@maiqueb: This pull request references Bugzilla bug 1897431, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/lgtm Holding so someone else can properly review this. Feel free to remove the hold whenever you want. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold release |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, maiqueb, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@dougbtv: All pull requests linked via external trackers have merged: Bugzilla bug 1897431 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went to go cherry-pick some updates, but, there was enough drift that I required a sync.
Associated with https://bugzilla.redhat.com/show_bug.cgi?id=1897431 due to I was cherry picking to resolve that issue.