Upstream sync, Nov 2022 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Julian <me@joejulian.name>
Signed-off-by: Casey Callendrello <cdc@redhat.com>
Previously, the bridge plugin ignored DNS settings returned from an IPAM plugin (e.g. the host-local plugin parsing resolv.conf to configure DNS). With this change, the bridge plugin uses IPAM DNS settings. Similarly to #388, this change will use incoming DNS settings if set, otherwise IPAM plugin returned DNS settings Signed-off-by: Kern Walster <walster@amazon.com>
Latest version fixes a segfault when used on some ppp setup Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
bridge: support IPAM DNS settings
Bump to go 1.18
Update github.com/vishvananda/netlink to v1.2.0-beta
Signed-off-by: mmirecki <mmirecki@redhat.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Unlike `rerun_url`, this endpoint isn't in the run API response, but we can construct it manually easily. Documentation for it is here: https://docs.github.com/en/rest/actions/workflow-runs#re-run-failed-jobs-from-a-workflow-run Signed-off-by: JP Simard <jp@jpsim.com>
build: support riscv64
ci: only rerun failed jobs on `/retest`
bug: return errors when iptables and ip6tables are unusable
Check for duplicated sysctl keys
Signed-off-by: Xiang Liu <lx1036@126.com>
Currently, hostname is set in the original DHCPREQUEST but not the renewal. With some DHCP server implementations (such as FreeBSD dhcpd), this leads to the hostname being cleared in the lease table. This behavior is inconsistent with other DHCP clients such as dhclient which set the hostname on the renewal request as well. To fix, use the same options for acquire and renew. This is compatible with RFC 2131 (see table 5). Signed-off-by: Akhil Velagapudi <4@4khil.com>
Use the same options for acquiring, renewing lease
bridge: update vlanFiltering variable to make code more readable
Leverages the Linux dummy interface type to create network interfaces that permists routing packets through the Linux kernel without them being transmitted. This solution allows use of arbitrary non-loopback IP addresses within the container. Related to #466 Signed-off-by: Mircea Iordache-Sica <mircea@arista.com>
These were previously left intact, even when exiting gracefully. As the daemon also fails if the socket already exists, it became the caller's responsibilityto check for and cleanup old socket files when performing graceful / deliberate restarts. Signed-off-by: Emily Shepherd <emily@redcoat.dev>
Signed-off-by: Jingyuan Liang <jingyuanliang@google.com>
Cleanup Socket and Pidfile on exit
host-local: remove unused Release(ip) from type Store interface
dummy: Create a Dummy CNI plugin that creates a virtual interface.
This commit changes the order of substituting sysctl path to first handle . to / change, before substituting the interface name. This is needed as vlan interfaces have a . in the name, which should not be changed. Signed-off-by: mmirecki <mmirecki@redhat.com>
Fix path substitution to enable setting sysctls on vlan interfaces
openshift-ci
bot
added
the
approved
|
@dougbtv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.