OCPBUGS-14095: Sync with upstream version v1.3.0 #98
Conversation
This commit updates ginkgo to v2. Note that because ginkgo/v2 requires go1.18, it was updated as well. Signed-off-by: liornoy <lnoy@redhat.com> Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
This commit updates the import of ginkgo to v2 in all of the tests. Signed-off-by: liornoy <lnoy@redhat.com> Co-authored-by: Sascha Grunert <sgrunert@redhat.com>
this prevents the error to be lost which was causing the panic while accesing a nil var. Fix #830 Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
Fix overwritten error var in getMTUByName
Update ginkgo to v2
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
ci(lint): setup yamllint linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
ci(lint): setup golangci-lint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
remove govet and gofmt from test_linux.sh
… linters Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Golangci-lint is now running version 1.52.1. This introduced some errors. Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Fix revive linter errors
enable durationcheck, predeclared, unconvert, unused and wastedassign linters
Signed-off-by: Marcelo Guerrero Viveros <marguerr@redhat.com>
Fix wastedassign linter errors
enable ginkgolinter linter
Use: - `BeEmpty` instead of `HaveLen(0)` - `Expect(x).To(BeZero())` instead of `Expect(x == 0).To(BeTrue())` Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
linter: fix ginkgolinter errors
Signed-off-by: Ivan Kolodyazhny <e0ne@e0ne.info>
…s/github.com/Microsoft/hcsshim-0.9.9 build(deps): bump github.com/Microsoft/hcsshim from 0.9.8 to 0.9.9
[sbr]: Ignore LinkNotFoundError during cmdDel
openshift-ci
bot
added
the
approved
|
@dougbtv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, mlguerrero12, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle OCPBUGS-14095: Sync with upstream version v1.3.0 |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@dougbtv: This pull request references Jira Issue OCPBUGS-14095, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@dougbtv: This pull request references Jira Issue OCPBUGS-14095, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@dougbtv: This pull request references Jira Issue OCPBUGS-14095, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mlguerrero12: This pull request references Jira Issue OCPBUGS-14095, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dougbtv: Jira Issue OCPBUGS-14095: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14095 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.