Set the contour image version used by the contour-operator #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the contour-operator uses the "latest" image to provision the resources for a Contour resource. However the not every contour image is guaranteed to work with every operator version. This change fixes the contour image version used by the operator. When updating the operator the contour image version will also have to be updated.
arjunrn
changed the title
| @@ -24,3 +24,4 @@ spec: | |||
| args: | |||
| - "--metrics-addr=127.0.0.1:8080" | |||
| - "--enable-leader-election" | |||
| - "--contour-image=docker.io/projectcontour/contour:v1.15.1" | |||
There was a problem hiding this comment.
I noticed that there is a v1.16.0 is that not applicable ?
There was a problem hiding this comment.
I haven't tested it with that particular version of contour. Once the CI is ready it should be easy to test the newer versions. Let's merge this.
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arjunrn, lmzuccarelli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the contour-operator uses the "latest" image to provision the resources for a Contour resource. However the not every contour image is guaranteed to work with every operator version. This change fixes the contour image version used by the operator. When updating the operator the contour image version will also have to be updated.