OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 #105

gcs278 · 2023-11-13T19:50:14Z

Cherry-Pick of coredns#6354 which fixes OCPBUGS-15755.

plugin/cache: key cache on Checking Disabled (CD) bit

Key the cache on CD bit, which effectively separates the entries for queries with CD disabled or enabled.

openshift-ci-robot · 2023-11-13T19:56:11Z

@gcs278: This pull request references Jira Issue OCPBUGS-15755, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-Pick of coredns#6354 which fixes OCPBUGS-15755.

plugin/cache: key cache on Checking Disabled (CD) bit

Key the cache on CD bit, which effectively separates the entries for queries with CD disabled or enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-11-13T19:56:14Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gcs278: This pull request references Jira Issue OCPBUGS-15755, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.15.0) matches configured target version for branch (4.15.0)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-Pick of coredns#6354 which fixes OCPBUGS-15755.

plugin/cache: key cache on Checking Disabled (CD) bit

Key the cache on CD bit, which effectively separates the entries for queries with CD disabled or enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-11-29T17:39:58Z

/assign

candita · 2023-11-29T20:20:01Z

/assign

candita · 2023-11-29T22:35:03Z

e2e-metal-ipi-ovn test failure:

go test -test.timeout 180m -v . -ginkgo.v -ginkgo.focus 'e2e\snon-vxlan\sexternal\sgateway\sthrough\sa\sgateway\spod' -ginkgo.timeout 3h -ginkgo.flake-attempts 2 '-ginkgo.skip=Should validate connectivity before and after deleting all the db-pods at once in Non-HA mode| e2e br-int NetFlow export validation|disabling egress nodes impeding Legacy health check|Multi Homing|Node IP address migration|Multi node zones interconnect|External Gateway|Kubevirt Virtual Machines' -provider skeleton -kubeconfig /root/ovn.conf --num-nodes=2 --report-dir=/root/dev-scripts/ovn-kubernetes/test/artifacts --report-prefix=control-plane
acl_logging.go:18:2: missing go.sum entry for module providing package k8s.io/kubernetes/test/e2e/framework (imported by github.com/ovn-org/ovn-kubernetes/test/e2e); to add:
go get github.com/ovn-org/ovn-kubernetes/test/e2e

candita · 2023-11-29T22:39:06Z

plugin/cache/cache_test.go

+		shouldCache bool
+	}{
+		{
+			name: "test ad bit cache",


I guess they didn't mind upstream that you removed informative comments, but I would have at least added a nit. Not much we'd want to do now.

I think the comments that were still relevant became test-case names. Some comments were reworded, and a few were deleted because they became untrue when the test was changed to create a new cache for each test case.

Right. They became test case names, and the ones that were removed, were removed due to not being accurate anymore due to updates in the test case.

candita · 2023-11-29T22:50:26Z

/approve

openshift-ci · 2023-11-29T22:50:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [candita]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2023-11-29T23:44:09Z

Please put the PR number instead of "<carry>" in the summary line of the commit message. See https://github.com/openshift/kubernetes/blob/59b90bd188d5389527a81d17e5787877d8c5746b/README.openshift.md#cherry-picking-an-upstream-change for documentation of the convention and openshift/kubernetes@f59457b for an example.

gcs278 · 2023-11-30T13:40:13Z

Please put the PR number instead of "" in the summary line of the commit message. See https://github.com/openshift/kubernetes/blob/59b90bd188d5389527a81d17e5787877d8c5746b/README.openshift.md#cherry-picking-an-upstream-change for documentation of the convention and openshift/kubernetes@f59457b for an example.

Thanks for the documentation - my first time seeing this. That makes sense. Done.

Miciah · 2023-12-02T04:28:23Z

The commit message has a typo: "6534" should be "6354".

plugin/cache: key cache on Checking Disabled (CD) bit (coredns#6354) * plugin/cache: key cache on Checking Disabled (CD) bit Key the cache on CD bit, which effectively separates the entries for queries with CD disabled or enabled. Signed-off-by: Grant Spence <gspence@redhat.com>

gcs278 · 2023-12-04T13:46:14Z

The commit message has a typo: "6534" should be "6354".

Good catch. Done.

gcs278 · 2023-12-08T14:15:27Z

/retest

gcs278 · 2023-12-08T16:09:34Z

/retest

Miciah · 2023-12-14T07:24:53Z

Thanks, and sorry for letting this PR languish!
/lgtm

openshift-ci-robot · 2023-12-14T07:56:13Z

/retest-required

Remaining retests: 0 against base HEAD 68ef945 and 2 for PR HEAD 59f7d2f in total

gcs278 · 2023-12-15T16:44:26Z

all cluster provisioning-type errors
/retest

gcs278 · 2023-12-18T15:55:59Z

/retest

gcs278 · 2023-12-18T19:22:47Z

Waiting for https://issues.redhat.com/browse/TRT-1420 to be fixed for e2e-gcp-serial

gcs278 · 2023-12-18T21:18:48Z

Should be fixed now
/test e2e-gcp-serial

openshift-ci · 2023-12-18T23:48:32Z

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-sdn-serial	`076c721`	link	true	`/test e2e-gcp-sdn-serial`
ci/prow/e2e-metal-ipi-ovn	`59f7d2f`	link	false	`/test e2e-metal-ipi-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-12-18T23:51:04Z

@gcs278: Jira Issue OCPBUGS-15755: All pull requests linked via external trackers have merged:

openshift/coredns#105

Jira Issue OCPBUGS-15755 has been moved to the MODIFIED state.

In response to this:

Cherry-Pick of coredns#6354 which fixes OCPBUGS-15755.

plugin/cache: key cache on Checking Disabled (CD) bit

Key the cache on CD bit, which effectively separates the entries for queries with CD disabled or enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-19T01:39:06Z

[ART PR BUILD NOTIFIER]

This PR has been included in build coredns-container-v4.16.0-202312190117.p0.gc92bb1a.assembly.stream for distgit coredns.
All builds following this will include this PR.

openshift-ci bot requested review from knobunc and Miciah November 13, 2023 19:50

gcs278 changed the title ~~UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755~~ OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 Nov 13, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 13, 2023

openshift-ci bot assigned Miciah Nov 29, 2023

openshift-ci bot assigned candita Nov 29, 2023

candita reviewed Nov 29, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023

gcs278 force-pushed the cache-cd-bit branch from 47e966c to 076c721 Compare November 30, 2023 13:38

gcs278 force-pushed the cache-cd-bit branch from 076c721 to 59f7d2f Compare December 4, 2023 13:46

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023

openshift-merge-bot bot merged commit c92bb1a into openshift:master Dec 18, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 #105

OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 #105

gcs278 commented Nov 13, 2023

openshift-ci-robot commented Nov 13, 2023

openshift-ci bot commented Nov 13, 2023

Miciah commented Nov 29, 2023

candita commented Nov 29, 2023

candita commented Nov 29, 2023

candita Nov 29, 2023

Miciah Nov 29, 2023

gcs278 Nov 30, 2023

candita commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

Miciah commented Nov 29, 2023 •

edited

gcs278 commented Nov 30, 2023

Miciah commented Dec 2, 2023

gcs278 commented Dec 4, 2023

gcs278 commented Dec 8, 2023

gcs278 commented Dec 8, 2023

Miciah commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

gcs278 commented Dec 15, 2023

gcs278 commented Dec 18, 2023

gcs278 commented Dec 18, 2023

gcs278 commented Dec 18, 2023

openshift-ci bot commented Dec 18, 2023

openshift-ci-robot commented Dec 18, 2023

openshift-bot commented Dec 19, 2023

OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 #105

OCPBUGS-15755: UPSTREAM: <carry>: openshift: Fix OCPBUGS-15755 #105

Conversation

gcs278 commented Nov 13, 2023

openshift-ci-robot commented Nov 13, 2023

openshift-ci bot commented Nov 13, 2023

Miciah commented Nov 29, 2023

candita commented Nov 29, 2023

candita commented Nov 29, 2023

candita Nov 29, 2023

Choose a reason for hiding this comment

Miciah Nov 29, 2023

Choose a reason for hiding this comment

gcs278 Nov 30, 2023

Choose a reason for hiding this comment

candita commented Nov 29, 2023

openshift-ci bot commented Nov 29, 2023

Miciah commented Nov 29, 2023 • edited

gcs278 commented Nov 30, 2023

Miciah commented Dec 2, 2023

gcs278 commented Dec 4, 2023

gcs278 commented Dec 8, 2023

gcs278 commented Dec 8, 2023

Miciah commented Dec 14, 2023

openshift-ci-robot commented Dec 14, 2023

gcs278 commented Dec 15, 2023

gcs278 commented Dec 18, 2023

gcs278 commented Dec 18, 2023

gcs278 commented Dec 18, 2023

openshift-ci bot commented Dec 18, 2023

openshift-ci-robot commented Dec 18, 2023

openshift-bot commented Dec 19, 2023

Miciah commented Nov 29, 2023 •

edited