Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31768: UPSTREAM: <carry>: Address CVE-2023-49295 and CVE-2024-22189 #108

Merged
merged 1 commit into from
May 9, 2024

Conversation

rfredette
Copy link

@rfredette rfredette commented Jan 22, 2024

bump github.com/quic-go/quic-go to v0.42.0 to get the fix for CVE-2023-49295 and CVE-2024-22189

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2024
@openshift-ci-robot
Copy link

@rfredette: This pull request references Jira Issue OCPBUGS-26973, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bump github.com/quic-go/quic-go to v0.37.7 to get the fix for CVE-2023-49295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 22, 2024
@openshift-ci openshift-ci bot requested review from candita and gcs278 January 22, 2024 18:27
@rfredette
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2024
@openshift-ci-robot
Copy link

@rfredette: This pull request references Jira Issue OCPBUGS-26973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 22, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rfredette: This pull request references Jira Issue OCPBUGS-26973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@candita
Copy link

candita commented Jan 24, 2024

/assign @gcs278

@melvinjoseph86
Copy link

/retest

@melvinjoseph86
Copy link

melvinjoseph86 commented Jan 30, 2024

Verified on pre-merged build

melvinjoseph@mjoseph-mac Downloads % oc get clusterversion                                           
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0.test-2024-01-30-060337-ci-ln-2mmr8f2-latest   True        False         3m21s   Cluster version is 4.16.0-0.test-2024-01-30-060337-ci-ln-2mmr8f2-latest

melvinjoseph@mjoseph-mac Downloads % oc rsync -n openshift-dns dns-default-84rgh:/usr/bin/coredns .
receiving file list ... done
coredns
sent 38 bytes  received 78463796 bytes  2342204.00 bytes/sec
total size is 78444560  speedup is 1.00
Defaulted container "dns" out of: dns, kube-rbac-proxy

melvinjoseph@mjoseph-mac Downloads % strings ./coredns >> forbug.txt                               
melvinjoseph@mjoseph-mac Downloads % grep -B1 "v0.37.7" forbug.txt                                 
github.com/quic-go/quic-go
v0.37.7
--
github.com/quic-go/quic-go
v0.37.7
melvinjoseph@mjoseph-mac Downloads % 

@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 30, 2024
@openshift-ci-robot
Copy link

@rfredette: This pull request references Jira Issue OCPBUGS-26973, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

bump github.com/quic-go/quic-go to v0.37.7 to get the fix for CVE-2023-49295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 30, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rfredette: This pull request references Jira Issue OCPBUGS-26973, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

bump github.com/quic-go/quic-go to v0.37.7 to get the fix for CVE-2023-49295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@melvinjoseph86
Copy link

/test e2e-metal-ipi-ovn

@candita
Copy link

candita commented May 8, 2024

/tide refresh

@rfredette rfredette changed the title OCPBUGS-26973: UPSTREAM: <carry>: Address CVE-2023-49295 OCPBUGS-26973, OCPBUGS-31768: UPSTREAM: <carry>: Address CVE-2023-49295 and CVE-2024-22189 May 9, 2024
@openshift-ci-robot
Copy link

@rfredette: This pull request references Jira Issue OCPBUGS-31768, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bump github.com/quic-go/quic-go to v0.37.7 to get the fix for CVE-2023-49295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@rfredette: This pull request references Jira Issue OCPBUGS-31768, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

bump github.com/quic-go/quic-go to v0.42.0 to get the fix for CVE-2023-49295 and CVE-2024-22189

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented May 9, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rfredette: This pull request references Jira Issue OCPBUGS-31768, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bump github.com/quic-go/quic-go to v0.37.7 to get the fix for CVE-2023-49295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 9, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: melvinjoseph86.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rfredette: This pull request references Jira Issue OCPBUGS-31768, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

bump github.com/quic-go/quic-go to v0.42.0 to get the fix for CVE-2023-49295 and CVE-2024-22189

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rfredette rfredette changed the title OCPBUGS-26973, OCPBUGS-31768: UPSTREAM: <carry>: Address CVE-2023-49295 and CVE-2024-22189 OCPBUGS-31768: UPSTREAM: <carry>: Address CVE-2023-49295 and CVE-2024-22189 May 9, 2024
bump github.com/quic-go/quic-go to v0.42.0 to get the fixes for CVE-2023-49295 and CVE-2024-22189

This fixes OCPBUGS-31768.
@gcs278
Copy link

gcs278 commented May 9, 2024

Straight forward fix.
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f937ebf and 2 for PR HEAD 5839299 in total

Copy link

openshift-ci bot commented May 9, 2024

@rfredette: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 32bf225 into openshift:master May 9, 2024
7 checks passed
@openshift-ci-robot
Copy link

@rfredette: Jira Issue OCPBUGS-31768: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31768 has been moved to the MODIFIED state.

In response to this:

bump github.com/quic-go/quic-go to v0.42.0 to get the fix for CVE-2023-49295 and CVE-2024-22189

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build coredns-container-v4.16.0-202405100946.p0.g32bf225.assembly.stream.el9 for distgit coredns.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-05-14-095225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants