test/e2e/manifest: hardcode StorageClass #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
EmilienM
added a commit
to shiftstack/dev-install
that referenced
this pull request
Jun 16, 2021
To make it easier to discover, let's rename the type that will be used for Manila CSI testing, to be `default` Technically it changes nothing but it'll make it so the Manila CSI operator will create a storage class with the name `csi-manila-default`; which is more generic than `csi-manila-cephfsnfstype`. More context: openshift/csi-driver-manila-operator#103
|
Looks good enough to me for our CI, where I expect manila share types to be static. |
The Storage Class is generated by the Manila CSI Operator, based on available share types that have been created in Manila. For CI purpose, we assume that a "default" share type exists and will be used for the StorageClass. If you run this manifest against an OpenStack cloud where there is no "default" share type, you'll need to change the value.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage Class is generated by the Manila CSI Operator, based on available
share types that have been created in Manila. For CI purpose, we assume
that a "default" share type exists and will be used for the StorageClass.
If you run this manifest against an OpenStack cloud where there is no "default" share type,
you'll need to change the value.