Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1835654: Update CSV manifest #18

Merged
merged 3 commits into from May 27, 2020
Merged

Bug 1835654: Update CSV manifest #18

merged 3 commits into from May 27, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented May 14, 2020 •
edited

This commit:

  1. Changes Operator version from 0.0.1 to 4.5.0 to comply with OpenShift requirements.
  2. Sets capabilities to Seamless Upgrades.
  3. Adds aos-storage-staff to the list of maintainers.
  4. Bumps minKubeVersion to 1.17.0

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented May 14, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2020
@Fedosin Fedosin changed the title Update CSV manifest Bug 1835654: Update CSV manifest May 19, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 19, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1835654, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1835654: Update CSV manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor Author

Fedosin commented May 19, 2020

/bugzilla refresh
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 19, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1835654, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh
/hold cancel
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 19, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1835654, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835654: Update CSV manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented May 21, 2020 •
edited

You should also add this annotation to CSV:

    "operatorframework.io/suggested-namespace": openshift-manila-csi-driver-operator

(or openshift-openstack-manila-csi-driver-operator?)

And remove namespace: manila-csi.

@Fedosin
Copy link
Contributor Author

Fedosin commented May 23, 2020

@jsafrane done! but we need to merge #23 first.

mandre
mandre reviewed May 26, 2020
View reviewed changes
bundle/manifests/csi-driver-manila-operator.v0.0.1.clusterserviceversion.yaml
@@ -1,7 +1,7 @@
apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
metadata:
name: csi-driver-manila-operator.v0.0.1
name: csi-driver-manila-operator.v4.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the file name be updated as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep :)

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 26, 2020
Merged
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2020
@jsafrane
Copy link
Contributor

this needs to be rebased

@Fedosin
Update CSV manifest
b3063ca 
This commit:
1. Changes Operator version from 0.0.1 to 4.5.0 to comply with OpenShift
   requirements.
2. Sets capebilities to Seamless Upgrades.
3. Adds aos-storage-staff to the list of maintainers.
4. Bumps minKubeVersion to 1.17.0
@Fedosin
Allow the operator to be installed only once
dc85b8d 
By using AllNamespaces installMode only. OLM won't allow the operator to be
installed for second time with this mode.
@Fedosin
Add suggested namespace for driver install
726298a
@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit d996585 into openshift:master May 27, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged: openshift/csi-driver-manila-operator#24, openshift/csi-driver-manila-operator#20, openshift/csi-driver-manila-operator#18. Bugzilla bug 1835654 has been moved to the MODIFIED state.

In response to this:

Bug 1835654: Update CSV manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@tombarron tombarron Awaiting requested review from tombarron

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fedosin @openshift-ci-robot @jsafrane @mandre @openshift-merge-robot