OCPBUGS-14049: Add secret informer #187
Conversation
openshift-ci-robot
added
jira/severity-important
|
@stephenfin: This pull request references Jira Issue OCPBUGS-14049, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Add a secret informer for the secret that we store credentials in, 'openshift-cluster-csi-drivers / manila-cloud-credentials', like we already do for the Cinder CSI Driver Operator. As is the case there, this ensures our controllers will reload upon changes to the secret. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
password-rotation-support-alt
branch
from
c27f02e
to
705fb00
Compare
|
/retest-required |
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stephenfin: Jira Issue OCPBUGS-14049: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-14049 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a secret informer for the secret that we store credentials in,
openshift-cluster-csi-drivers / manila-cloud-credentials, like we already do for the Cinder CSI Driver Operator. As is the case there, this ensures our controllers will reload upon changes to the secret.This is an alternative approach to #184 and not yet tested.