Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove local manifests #208

Merged
merged 1 commit into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ The operator is based on [openshift/library-go](https://github.com/openshift/lib
* If there is no Manila service, it marks the `ClusterCSIDriver` instance with `ManilaControllerDisabled: True` condition. It does not stop any CSI drivers started when Manila service was present! This allows pod to at least unmount their volumes.
* `secretSyncController`: Syncs Secret provided by cloud-credentials-operator into a new Secret that is used by the CSI drivers. The drivers need OpenStack credentials in different format than provided by cloud-credentials-operator.

## Usage

Check deployment YAML files in `manifests/` directory.
The operator is deployed and managed by another operator, the [Cluster Storage Operator](https://github.com/openshift/cluster-storage-operator). You can find the manifests that this operator uses [here](https://github.com/openshift/cluster-storage-operator/tree/master/assets/csidriveroperators/manila).

The operator makes few assumptions about the namespace where it runs:

* OpenStack cloud credentials are in Secret named "cloud-credentials" in the same namespace where the operator runs. The operator uses the credentials to check if Manila is present in the cluster and, since OpenStack does not allow any fine-grained access control, it lets the CSI driver to use the same credentials.
* OpenStack cloud credentials are in Secret named `cloud-credentials` in the same namespace where the operator runs. The operator uses the credentials to check if Manila is present in the cluster and, since OpenStack does not allow any fine-grained access control, it lets the CSI driver to use the same credentials.
* If underlying OpenStack uses self-signed certificate, the operator expects the certificate is present in a ConfigMap named "cloud-provider-config" with key "ca-bundle.pem" in the namespace where it runs. Generally, it should be a copy of "openshift-config/cloud-provider-config" ConfigMap. It then uses the certificate to talk to OpenStack API.
* The operand (= the CSI driver) must run in the same namespace as the operator, for the same reason as above - it uses the same self-signed OpenStack certificate, if provided.
5 changes: 0 additions & 5 deletions manifests/02_sa.yaml

This file was deleted.

40 changes: 0 additions & 40 deletions manifests/03_role.yaml

This file was deleted.

13 changes: 0 additions & 13 deletions manifests/04_rolebinding.yaml

This file was deleted.

251 changes: 0 additions & 251 deletions manifests/05_clusterrole.yaml

This file was deleted.

12 changes: 0 additions & 12 deletions manifests/06_clusterrolebinding.yaml

This file was deleted.