Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-191: add e2e tests #18

Merged
merged 2 commits into from Jan 15, 2021
Merged

BUILD-191: add e2e tests #18

merged 2 commits into from Jan 15, 2021

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Jan 6, 2021

/assign @coreydaley

this should over the scenarios discussed in the README

my thought is that once we've reviewed / iterate / merge, possible next steps:

  1. go ahead and craft "interim" PRs in openshift/release to see if PR test jobs will work where the deploy via ./deploy/deploy.sh works in CI
  2. then circle back with the OLM work in BUILD-159 and integrate / install via that form

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit e08970a into openshift:master Jan 15, 2021
@gabemontero gabemontero deleted the add-e2e-guts branch January 15, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants