STOR-1441: Restart node Pods if metrics-serving-cert changed

[mpatlasov]

Adding WithSecretHashAnnotationHook() for shared-resource-csi-driver-node-metrics-serving-cert ensures that new annotation is published in shared-resource-csi-driver-node DaemonSet. This, in turn, leads to node pods restart.

[openshift-ci-robot]

@mpatlasov: This pull request references STOR-1441 which is a valid jira issue.

In response to this:

Adding WithSecretHashAnnotationHook() for shared-resource-csi-driver-node-metrics-serving-cert ensures that new annotation is published in shared-resource-csi-driver-node DaemonSet. This, in turn, leads to node pods restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mpatlasov]

/label docs-approved
/label px-approved
/approve

[adambkaplan]

@mpatlasov out of curiosity, how often is this cert rotated in a typical OpenShift cluster? What is the impact in a large cluster (say 1,000 worker nodes)?

[adambkaplan]

/approve

Marking as approved to unblock lgtm.

@mpatlasov can you please amend your commit with a description justifying the change? This will help future maintainers understand why we need to restart the pods if the metrics-serving-cert is changed/rotated.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

Pre verifiy passed with the pre merged build 4.14.0-0.ci.test-2023-08-10-084739-ci-ln-t81vb0b-latest

# After the metrics-serving-cert secret changed, driver controller restarted
$ oc delete secret shared-resource-csi-driver-node-metrics-serving-cert
secret "shared-resource-csi-driver-node-metrics-serving-cert" deleted

$ oc get po -l app=shared-resource-csi-driver-node -w
NAME                                    READY   STATUS        RESTARTS   AGE
shared-resource-csi-driver-node-4r2lb   2/2     Terminating   2          40m
shared-resource-csi-driver-node-76s97   2/2     Running       0          11s
shared-resource-csi-driver-node-v8xqq   2/2     Running       0          40m
shared-resource-csi-driver-node-4r2lb   0/2     Terminating   2          40m
shared-resource-csi-driver-node-fchkb   0/2     Pending       0          0s
shared-resource-csi-driver-node-fchkb   0/2     Pending       0          0s
shared-resource-csi-driver-node-fchkb   0/2     Pending       0          0s
shared-resource-csi-driver-node-fchkb   0/2     ContainerCreating   0          0s
shared-resource-csi-driver-node-fchkb   0/2     ContainerCreating   0          0s
shared-resource-csi-driver-node-4r2lb   0/2     Terminating         2          40m
shared-resource-csi-driver-node-4r2lb   0/2     Terminating         2          40m
shared-resource-csi-driver-node-4r2lb   0/2     Terminating         2          40m
shared-resource-csi-driver-node-fchkb   2/2     Running             0          1s
shared-resource-csi-driver-node-v8xqq   2/2     Terminating         0          40m
shared-resource-csi-driver-node-v8xqq   0/2     Terminating         0          41m
shared-resource-csi-driver-node-j4mlm   0/2     Pending             0          0s
shared-resource-csi-driver-node-v8xqq   0/2     Terminating         0          41m
shared-resource-csi-driver-node-j4mlm   0/2     Pending             0          0s
shared-resource-csi-driver-node-j4mlm   0/2     Pending             0          0s
shared-resource-csi-driver-node-j4mlm   0/2     ContainerCreating   0          0s
shared-resource-csi-driver-node-v8xqq   0/2     Terminating         0          41m
shared-resource-csi-driver-node-v8xqq   0/2     Terminating         0          41m
shared-resource-csi-driver-node-j4mlm   0/2     ContainerCreating   0          0s
shared-resource-csi-driver-node-j4mlm   2/2     Running             0          1s

$ oc get po -l app=shared-resource-csi-driver-node
NAME                                    READY   STATUS    RESTARTS   AGE
shared-resource-csi-driver-node-76s97   2/2     Running   0          8m4s
shared-resource-csi-driver-node-fchkb   2/2     Running   0          7m31s
shared-resource-csi-driver-node-j4mlm   2/2     Running   0          6m59s

[Phaow]

/label qe-approved

[jsafrane]

Our doc says OCP rotates certificates every 13 months, unless admins asks earlier

[mpatlasov]

Hi @adambkaplan , I updated the commit description with some words explaining why we need to restart pods. As for your previous questions, see please Jan's comment above: CA cert is rotated very rarely, once in 13 months. As for impact in a large cluster, TBH I can't see why we should expect severe impact: end-users will keep using their existing PVs while CSI driver pods restarting, and new CA cert is a big deal anyway.

[openshift-ci]

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

/lgtm