BUILD-234: Add cross platform build support in Makefile #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gabemontero /cc @otaviof @coreydaley |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
gabemontero
reviewed
Sep 13, 2021
- Allow target GOOS and GOARCH to be configurable with TARGET_GOOS and TARGET_GOARCH variables - Add race detection only if compiling for amd64. - Remove ldflags that break compilation on s390x.
adambkaplan
force-pushed
the
rm-race-flag
branch
from
570f371
to
f9fddcd
Compare
adambkaplan
changed the title
|
@gabemontero @otaviof updated Makefile such that we can compile on Power and Z. I may want to follow up with a |
|
unrelated flake /retest /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOOSandGOARCHto be configurable withTARGET_GOOSandTARGET_GOARCHvariables