Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29728: cherry-pick:release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch #141

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 7, 2024

Cherry-pick of commit ff71329 to branch release-4.13 to reduce flakes as seen in openshift/oadp-operator#1277
OCPBUGS-29244

@kaovilai kaovilai force-pushed the cherry-pick-ff71329-ocp/release-4.13 branch 2 times, most recently from ff4d8ed to 53b1f4f Compare February 7, 2024 21:43
@kaovilai kaovilai force-pushed the cherry-pick-ff71329-ocp/release-4.13 branch from 53b1f4f to edaac7c Compare February 7, 2024 21:50
Copy link

openshift-ci bot commented Feb 7, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai changed the title Cherry-pick Update VolumeSnapshot and VolumeSnapshotContent using JSON patch to release-4.13 Cherry-pick:cherry-pick-ff71329-ocp/release-4.13 OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch Feb 8, 2024
@kaovilai kaovilai changed the title Cherry-pick:cherry-pick-ff71329-ocp/release-4.13 OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch Cherry-pick: release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch Feb 8, 2024
@kaovilai kaovilai changed the title Cherry-pick: release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch cherry-pick:release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch Feb 8, 2024
@mpatlasov
Copy link

/retitle OCPBUGS-29728: cherry-pick:release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch

@openshift-ci openshift-ci bot changed the title cherry-pick:release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch OCPBUGS-29728: cherry-pick:release-4.13: OCPBUGS-29244 Update VolumeSnapshot and VolumeSnapshotContent using JSON patch Feb 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2024
@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-29728, which is invalid:

  • expected Jira Issue OCPBUGS-29728 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of commit ff71329 to branch release-4.13 to reduce flakes as seen in openshift/oadp-operator#1277
OCPBUGS-29244

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link

/lgtm
/approve
/label backport-risk-assessed
/label cherry-pick-approved
/jira refresh

@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-29728, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29433 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/label cherry-pick-approved
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

@mpatlasov: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/lgtm
/approve
/label backport-risk-assessed
/label cherry-pick-approved
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@mpatlasov
Copy link

/assign @gnufied for approval

Copy link

openshift-ci bot commented Feb 20, 2024

@mpatlasov: GitHub didn't allow me to assign the following users: for, approval.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gnufied for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member

gnufied commented Feb 20, 2024

Usually it is not a good idea to patch things this way, but that is a discussion for another PR.

/approve

@gnufied
Copy link
Member

gnufied commented Feb 20, 2024

/lgtm

Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, kaovilai, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@duanwei33
Copy link

QE is performing pre-merge verification with the open PR.

@duanwei33
Copy link

/label cherry-pick-approved

@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Feb 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 22, 2024
@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-29728, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29433 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29433 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

Cherry-pick of commit ff71329 to branch release-4.13 to reduce flakes as seen in openshift/oadp-operator#1277
OCPBUGS-29244

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@duanwei33: This pull request references Jira Issue OCPBUGS-29728, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29433 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29433 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c8a7a09 into openshift:release-4.13 Feb 22, 2024
6 checks passed
@openshift-ci-robot
Copy link

@kaovilai: Jira Issue OCPBUGS-29728: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29728 has been moved to the MODIFIED state.

In response to this:

Cherry-pick of commit ff71329 to branch release-4.13 to reduce flakes as seen in openshift/oadp-operator#1277
OCPBUGS-29244

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-csi-external-snapshotter-container-v4.13.0-202402221608.p0.gc8a7a09.assembly.stream.el8 for distgit ose-csi-external-snapshotter.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.13.0-0.nightly-2024-02-22-211710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet