OCPBUGS-31439: Backport volumegroupsnapshot fixes to OCP 4.16 #146
Conversation
Currently the RestoreSize is missing when the corresponding VSC are created for the the volumesnapshotgroup, This PR adds the missing RestoreSize for VSC. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating code to use correct method names for logging. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
use GroupSnapshotDeleteError as event type for event incase if there is any failure in delete operation. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
…otClass The `IsDefaultAnnotation()` function has been extended to check for the correct default annotation, taking the Kind of the object into consideration.
…oller. Fixes: kubernetes-csi#834 Signed-off-by: Manish <myathnal@redhat.com>
openshift-ci-robot
added
jira/valid-reference
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-31439, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-31439, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/label docs-approved |
openshift-ci
bot
added
docs-approved
|
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
@mpatlasov: Jira Issue OCPBUGS-31439: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31439 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-csi-snapshot-validation-webhook-container-v4.16.0-202404031748.p0.g795fa18.assembly.stream.el9 for distgit csi-snapshot-validation-webhook. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-04-05-052913 |
Cherry-pick commits from upstream PRs:
@openshift/storage