Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31746: Backport volumegroupsnapshot fixes to OCP 4.16 #148

Conversation

mpatlasov
Copy link

Cherry-pick commit from upstream PR: use group secret for GetGroupSnapshotStatus

@openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2024
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-31746, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick commit from upstream PR: use group secret for GetGroupSnapshotStatus

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 4, 2024
@openshift-ci openshift-ci bot requested review from dobsonj and jsafrane April 4, 2024 23:54
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@mpatlasov
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2024
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-31746, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link
Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Apr 4, 2024
Use the right groupsnapshot secret for the group
operations.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
GetGroupSnapshotStatus is a group operation on
a specific group with an ID, we can use the
group specific secret instead of List specific
secret.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mpatlasov mpatlasov force-pushed the OCPBUGS-31746-Backport-volumegroupsnapshot-fixes branch from 33116bc to 08effea Compare April 5, 2024 19:38
Copy link

openshift-ci bot commented Apr 5, 2024

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Apr 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5315d37 into openshift:master Apr 8, 2024
7 checks passed
@openshift-ci-robot
Copy link

@mpatlasov: Jira Issue OCPBUGS-31746: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31746 has been moved to the MODIFIED state.

In response to this:

Cherry-pick commit from upstream PR: use group secret for GetGroupSnapshotStatus

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-csi-snapshot-controller-container-v4.16.0-202404080846.p0.g5315d37.assembly.stream.el9 for distgit ose-csi-snapshot-controller.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants