Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1750: Build image from legacy folder #162

Merged
merged 4 commits into from Feb 14, 2024
Merged

STOR-1750: Build image from legacy folder #162

merged 4 commits into from Feb 14, 2024

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 13, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1750 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes https://issues.redhat.com/browse/STOR-1750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Squashed 'legacy/azure-file-csi-driver-operator/' changes from bdaf20…
f51953b 
…62d..16af90e5a

16af90e5a Merge pull request openshift#100 from jsafrane/STOR-1574-origin-main
7a375e962 Merge pull request openshift#101 from openshift-bot/art-consistency-openshift-4.16-azure-file-csi-driver-operator
b857f6806 Updating ose-azure-file-csi-driver-operator-container image to be consistent with ART for 4.16 Reconciling with https://github.com/openshift/ocp-build-data/tree/a68ac2d64a2e3bcf927ae39410024a4c1140177a/images/azure-file-csi-driver-operator.yml
4fdc71fa1 Bump all deps

git-subtree-dir: legacy/azure-file-csi-driver-operator
git-subtree-split: 16af90e5a6d124de17c1c20e5320648d3dc04c53
@gnufied
Merge commit 'f51953bf3fc3024caca748b68ed4d730284c2d00' into build-im…
7d43541 
…age-from-legacy-folder
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-csi-extended 7d43541 link false /test e2e-azure-csi-extended
ci/prow/e2e-azurestack-csi 7d43541 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bertinatto
bertinatto reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@gnufied
Copy link
Member Author

gnufied commented Feb 14, 2024

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Feb 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot

@gnufied: This pull request references STOR-1750 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes https://issues.redhat.com/browse/STOR-1750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7e6fc22 into openshift:master Feb 14, 2024
13 of 15 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.16.0-202402150209.p0.g7e6fc22.assembly.stream.el9 for distgit ose-azure-disk-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnufied @openshift-ci-robot @openshift-bot @bertinatto