STOR-1762: Add azure file hypershift #163
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gnufied: This pull request references STOR-1762 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
gnufied
force-pushed
the
add-azure-file-hypershift
branch
from
a259a4c
to
9e370b7
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
|
/retest |
|
It looks very good overall! |
|
/retest |
|
@gnufied: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
openshift-ci
bot
added
the
px-approved
|
/retest |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@gnufied: This pull request references STOR-1762 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 74590de
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.16.0-202402271510.p0.g74590de.assembly.stream.el9 for distgit ose-aws-ebs-csi-driver-operator. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.16.0-202402271510.p0.g74590de.assembly.stream.el9 for distgit ose-azure-disk-csi-driver-operator. |
Assets `main_snapshotter_binding.yaml` were never used: `generator` does not generate them, `manifests.yaml` files do not mention them, and in alive Azure cluster: ``` $ oc get ClusterRoleBinding -n openshift-cluster-csi-drivers azure-file-csi-main-snapshotter-binding Error from server (NotFound): clusterrolebindings.rbac.authorization.k8s.io "azure-file-csi-main-snapshotter-binding" not found ``` Most likely openshift#163 brought them by mistake.
Fixes https://issues.redhat.com/browse/STOR-1762