STOR-1726: Bump openshift/api dependency
#169
Conversation
`go get -u github.com/openshift/api && go mod tidy && go mod vendor` New api brings the const `SambaCSIDriver` which is necessary for implementation of smb driver operator.
|
@mpatlasov: This pull request references STOR-1726 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
px-approved
|
/assign @jsafrane |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc @openshift/storage |
|
@mpatlasov: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mpatlasov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Pre merge test passed with $ oc apply -f ccd.yaml
The ClusterCSIDriver "aaa.csi.aws.com" is invalid:
* metadata.name: Unsupported value: "aaa.csi.aws.com": supported values: "ebs.csi.aws.com", "efs.csi.aws.com", "disk.csi.azure.com", "file.csi.azure.com", "filestore.csi.storage.gke.io", "pd.csi.storage.gke.io", "cinder.csi.openstack.org", "csi.vsphere.vmware.com", "manila.csi.openstack.org", "csi.ovirt.org", "csi.kubevirt.io", "csi.sharedresource.openshift.io", "diskplugin.csi.alibabacloud.com", "vpc.block.csi.ibm.io", "powervs.csi.ibm.com", "secrets-store.csi.k8s.io", "smb.csi.k8s.io"
* <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation
$ oc apply -f ccd.yaml
clustercsidriver.operator.openshift.io/smb.csi.k8s.io created
$ oc get clustercsidriver
NAME AGE
ebs.csi.aws.com 110m
smb.csi.k8s.io 18s |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@mpatlasov: This pull request references STOR-1726 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 5323af6
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.16.0-202402210509.p0.g5323af6.assembly.stream.el9 for distgit ose-aws-ebs-csi-driver-operator. |
go get -u github.com/openshift/api && go mod tidy && go mod vendorNew api brings the const
SambaCSIDriverwhich is necessary for implementation of smb driver operator./label px-approved
/label docs-approved