Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-482: set required-scc for openshift workloads #170

Merged
merged 1 commit into from Apr 17, 2024
Merged

AUTH-482: set required-scc for openshift workloads #170

merged 1 commit into from Apr 17, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Feb 20, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link
Contributor

/test e2e-azure-file-csi

@mpatlasov
Copy link
Contributor

If I understand this PR correctly, it adds openshift.io/required-scc: restricted-v2 only to aws-ebs-csi-driver-controller pods and deployment. Based on this must-gather file, all aws-ebs-csi-driver-controller pods run with annotation "openshift.io/scc": "restricted-v2". Hence, adding openshift.io/required-scc: restricted-v2 must be safe.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@liouk
Copy link
Member Author

liouk commented Feb 22, 2024

If I understand this PR correctly, it adds openshift.io/required-scc: restricted-v2 only to aws-ebs-csi-driver-controller pods and deployment. Based on this must-gather file, all aws-ebs-csi-driver-controller pods run with annotation "openshift.io/scc": "restricted-v2". Hence, adding openshift.io/required-scc: restricted-v2 must be safe.

Thank you for verifying this @mpatlasov -- indeed I have chosen the SCC with which the pods are in fact getting admitted.

@liouk liouk changed the title AUTH-482: set required-scc for openshift workloads WIP: AUTH-482: set required-scc for openshift workloads Feb 28, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@liouk liouk changed the title AUTH-482: set required-scc for openshift workloads WIP: AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@liouk
Copy link
Member Author

liouk commented Apr 5, 2024

/retest-required

@liouk
Copy link
Member Author

liouk commented Apr 9, 2024

Hi @mpatlasov, I added some changes (basically added the annotation in assets/base/node.yaml and generated manifests properly), so /lgtm was dropped. Could you please take another look? Thanks!

@mpatlasov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@liouk
Copy link
Member Author

liouk commented Apr 11, 2024

No impact on docs or product experience.

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Apr 11, 2024
@Phaow
Copy link
Contributor

Phaow commented Apr 12, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1e686fe and 2 for PR HEAD 40c3a9b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b62f0a9 and 1 for PR HEAD 40c3a9b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a2eacce and 0 for PR HEAD 40c3a9b in total

@openshift-ci-robot
Copy link

/hold

Revision 40c3a9b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2024
@jsafrane
Copy link
Contributor

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cdf7b2a and 2 for PR HEAD 40c3a9b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4779019 and 1 for PR HEAD 40c3a9b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d3f0705 and 0 for PR HEAD 40c3a9b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024 •
edited

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 40c3a9b link false /test e2e-azurestack-csi
ci/prow/e2e-azure-csi-extended 40c3a9b link false /test e2e-azure-csi-extended
ci/prow/e2e-azure-file-csi-extended 40c3a9b link false /test e2e-azure-file-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 40c3a9b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@jsafrane
Copy link
Contributor

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d7e1d3c into openshift:master Apr 17, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatlasov mpatlasov mpatlasov approved these changes

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees

@mpatlasov mpatlasov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liouk @openshift-ci-robot @mpatlasov @Phaow @jsafrane @openshift-merge-robot