OCPBUGS-23260: Explicitly reserve 1 attachment for the root disk

[jsafrane]

Using a newly introduced option --reserved-volume-attachments, explicitly reserve 1 AWS EBS volume attachment for the root disk and leave the other attachment to PVs/PVCs.

This disables bad heuristics in the CSI driver, see the linked bug.

/hold
for openshift/aws-ebs-csi-driver#260 to be merged first

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-23260, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Using a newly introduced option --reserved-volume-attachments, explicitly reserve 1 AWS EBS volume attachment for the root disk and leave the other attachment to PVs/PVCs.

This disables bad heuristics in the CSI driver, see the linked bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/retest

[jsafrane]

/hold cancel

[bertinatto]

/lgtm

[bertinatto]

/retest-required

[Phaow]

/retest

[jsafrane]

/jira refresh

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-23260, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Phaow

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/label acknowledge-critical-fixes-only
This is an important bugfix

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 921361a and 2 for PR HEAD 97beb14 in total

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-file-csi-extended	97beb14	link	false	/test e2e-azure-file-csi-extended
ci/prow/e2e-azurestack-csi	97beb14	link	false	/test e2e-azurestack-csi
ci/prow/e2e-azure-csi-extended	97beb14	link	false	/test e2e-azure-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jsafrane: Jira Issue OCPBUGS-23260: All pull requests linked via external trackers have merged:

• openshift/csi-operator#199
• openshift/aws-ebs-csi-driver#260

Jira Issue OCPBUGS-23260 has been moved to the MODIFIED state.

In response to this:

Using a newly introduced option --reserved-volume-attachments, explicitly reserve 1 AWS EBS volume attachment for the root disk and leave the other attachment to PVs/PVCs.

This disables bad heuristics in the CSI driver, see the linked bug.

/hold
for openshift/aws-ebs-csi-driver#260 to be merged first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.16.0-202403180813.p0.g4b90682.assembly.stream.el9 for distgit azure-file-csi-driver-operator.
All builds following this will include this PR.

[jsafrane]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@jsafrane: new pull request created: #222

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.