Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1726: Add test manifest for SMB CSI driver #212

Merged
merged 2 commits into from
Apr 12, 2024
Merged

STOR-1726: Add test manifest for SMB CSI driver #212

merged 2 commits into from
Apr 12, 2024

Conversation

jsafrane
Copy link
Contributor

Together with a yaml file to run a simple samba server.

I expect I will need some changes in the samba-server yaml, but I need to start with something to be able to experiment with CI.

@openshift/storage

@jsafrane
Add test manifest for SMB CSI driver
d4c65e2 
Together with a yaml file to run a simple samba server.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Together with a yaml file to run a simple samba server.

I expect I will need some changes in the samba-server yaml, but I need to start with something to be able to experiment with CI.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member

dobsonj commented Apr 11, 2024

looks reasonable to start with
/lgtm
/approve
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 11, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Together with a yaml file to run a simple samba server.

I expect I will need some changes in the samba-server yaml, but I need to start with something to be able to experiment with CI.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3eebe00 and 2 for PR HEAD d4c65e2 in total

mpatlasov
mpatlasov reviewed Apr 11, 2024
View reviewed changes
test/e2e/samba/samba-server.yaml Outdated
name: samba-container-config
volumeClaimTemplates:
- metadata:
name: data2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as a leftover. I think we can remove volumeClaimTemplates: section altogether.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7c0afb and 1 for PR HEAD d4c65e2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1e686fe and 0 for PR HEAD d4c65e2 in total

@jsafrane
Add persistent volume to testing samba-server
8a6b1d5 
The samba server now uses a persistent volume. To allow anyone acces the
volume, explicitly chmod its root dir to 0777 in an init container.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-csi-extended 8a6b1d5 link false /test e2e-azure-file-csi-extended
ci/prow/e2e-azure-csi-extended 8a6b1d5 link false /test e2e-azure-csi-extended
ci/prow/e2e-azurestack-csi 8a6b1d5 link false /test e2e-azurestack-csi
ci/prow/e2e-aws-csi-extended 8a6b1d5 link false /test e2e-aws-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Apr 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b62f0a9 into openshift:master Apr 12, 2024
14 of 18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.16.0-202404121144.p0.gb62f0a9.assembly.stream.el9 for distgit ose-azure-disk-csi-driver-operator.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.16.0-202404121144.p0.gb62f0a9.assembly.stream.el9 for distgit ose-aws-ebs-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpatlasov mpatlasov mpatlasov left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsafrane @openshift-ci-robot @dobsonj @openshift-bot @mpatlasov