Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1726: Delete static resources when ClusterCSIDriver is removed #215

Merged
merged 2 commits into from
Apr 17, 2024
Merged

STOR-1726: Delete static resources when ClusterCSIDriver is removed #215

merged 2 commits into from
Apr 17, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Apr 12, 2024 •
edited

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable will not define conditional functions, and will behave the same as before with the static resources controller.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
  name: smb.csi.k8s.io
spec:
  managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable still use the conditional static resources controller, but getOperatorSyncState immediately returns Managed, which should behave exactly as before.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
 name: smb.csi.k8s.io
spec:
 managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable still use the conditional static resources controller, but getOperatorSyncState immediately returns Managed, which should behave exactly as before.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
 name: smb.csi.k8s.io
spec:
 managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable still use the conditional static resources controller, but getOperatorSyncState returns Managed, and should behave the same as before.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
 name: smb.csi.k8s.io
spec:
 managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member Author

dobsonj commented Apr 13, 2024

/test smb-operator-e2e

jsafrane
jsafrane reviewed Apr 15, 2024
View reviewed changes
pkg/operator/starter.go Outdated
}
// return the state from the operator if it's not managed
if opSpec.ManagementState != opv1.Managed {
return opSpec.ManagementState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will allow users to set managementState: Removed for CSI drivers that are not removable and the operator will remove.

That's an interesting feature that would allow users to disable e.g. vSphere CSI driver on clusters that don't want it installed. But I think it should be discussed first.

For now and for non-removable CSI drivers, Removed should be handled as Managed (?) and should throw some sane error. Returning err would degrade the cluster. It may be too strong, but it's the easiest thing to do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, I reworked this in a second commit to maintain the existing behavior.

NewStaticResourcesController sets the conditional resource functions to nil by default, which is interpreted by WithConditionalResources as "always create, never delete". So it's perfectly valid to pass nil functions into WithConditionalStaticResourcesController and it will behave exactly as WithStaticResourcesController did.

So now removable operators set the conditional functions, and non-removable operators leave them nil for the simple static resources controller they always used before.

For removable operators, I changed getOperatorSyncState to be consistent with how we manage static resources in gcp-filestore. It will not sync the resources if there is an error or if the state is not Managed, and it removes them only if DeletionTimestamp is set.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2024 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable will not define conditional functions, and will behave the same as before with the static resources controller.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
 name: smb.csi.k8s.io
spec:
 managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member Author

dobsonj commented Apr 16, 2024

/retest

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Apr 17, 2024

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2024 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR allows the smb-csi-driver-operator to clean up its static resources when the ClusterCSIDriver is removed.

The approach is the same as openshift/secrets-store-csi-driver-operator#8 (see also: secrets-store enhancement). This should allow us to follow a standard approach when moving other OLM operators to csi-operator just by setting Removable: true in the OperatorConfig.

Operators which are not removable will not define conditional functions, and will behave the same as before with the static resources controller.

Simple manual test:

  1. Create ClusterCSIDriver and wait for operator to create static resources:
$ oc apply -f - <<EOF
apiVersion: operator.openshift.io/v1
kind: ClusterCSIDriver
metadata:
 name: smb.csi.k8s.io
spec:
 managementState: Managed
EOF
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h48m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h55m
smb-csi-driver-controller-84546d6b8c-cdb75       3/3     Running   0          25s
smb-csi-driver-controller-84546d6b8c-cmgln       3/3     Running   0          25s
smb-csi-driver-node-5dn4m                        3/3     Running   0          23s
smb-csi-driver-node-fg2sc                        3/3     Running   0          23s
smb-csi-driver-node-kb4h6                        3/3     Running   0          23s
smb-csi-driver-node-llnsv                        3/3     Running   0          23s
smb-csi-driver-node-qhfkw                        3/3     Running   0          23s
smb-csi-driver-node-s5c2p                        3/3     Running   0          23s
  1. Delete ClusterCSIDriver and wait for operator to delete static resources:
$ oc delete clustercsidriver smb.csi.k8s.io
clustercsidriver.operator.openshift.io "smb.csi.k8s.io" deleted
$ oc get pods -n openshift-cluster-csi-drivers
NAME                                             READY   STATUS    RESTARTS   AGE
aws-ebs-csi-driver-controller-7b6cdd676b-745sm   11/11   Running   0          5h55m
aws-ebs-csi-driver-controller-7b6cdd676b-rsnpk   11/11   Running   0          5h55m
aws-ebs-csi-driver-node-5q94r                    3/3     Running   0          5h52m
aws-ebs-csi-driver-node-chs2m                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-kz24v                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-q9dj6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-node-qt29w                    3/3     Running   0          5h49m
aws-ebs-csi-driver-node-x2wb6                    3/3     Running   0          5h55m
aws-ebs-csi-driver-operator-5bf867fdd6-27x9f     1/1     Running   0          5h56m

/cc @openshift/storage @jsafrane @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 4afd4b1 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ef2c2ec into openshift:master Apr 17, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dobsonj @openshift-ci-robot @jsafrane