STOR-1726: auto-generate assets for CIFS/Samba driver #217
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mpatlasov: This pull request references STOR-1726 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I can see smb-operator-e2e did not pass, probably a typo somewhere around livenessprobe. |
|
/test smb-operator-e2e |
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
2 times, most recently
from
1fde1f2
to
8906c4f
Compare
|
Last force-push rebased local branch to the head of origin/master (commit 097858b) |
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
from
8906c4f
to
93ab3a3
Compare
|
Last force-push fixed a typo in |
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
from
93ab3a3
to
909b6fa
Compare
|
Last force-push fixed a typo in |
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
from
909b6fa
to
5e3a672
Compare
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
from
5e3a672
to
9860463
Compare
The patch ensures that all assets in `overlays/samba/generated/standalone` are generated by `generator`. Resulting assets survive simple dynamic-provisioning test with `test/e2e/samba/samba-server.yaml`
If we have 9212 in service.yaml:
```
ports:
- name: provisioner-m
port: 9212
```
the same port 9212 must be used in corresponding part of controller.yaml:
```
- args:
- --secure-listen-address=0.0.0.0:9212
- --upstream=http://127.0.0.1:8212/
- --tls-cert-file=/etc/tls/private/tls.crt
- --tls-private-key-file=/etc/tls/private/tls.key
- --tls-cipher-suites=${TLS_CIPHER_SUITES}
- --tls-min-version=${TLS_MIN_VERSION}
- --logtostderr=true
image: ${KUBE_RBAC_PROXY_IMAGE}
imagePullPolicy: IfNotPresent
name: provisioner-kube-rbac-proxy
ports:
- containerPort: 9212
name: provisioner-m
```
mpatlasov
force-pushed
the
STOR-1726-generate-assets-using-generator
branch
from
9860463
to
ad038fd
Compare
|
/test e2e-azure-ovn-upgrade |
|
Last force-push:
|
|
/test e2e-azure-ovn-upgrade |
|
/lgtm |
|
/test e2e-azure-ovn-upgrade |
2 similar comments
|
/test e2e-azure-ovn-upgrade |
|
/test e2e-azure-ovn-upgrade |
|
@mpatlasov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-azure-ovn-upgrade |
|
/label docs-approved We do post-merge tests, when it gets to OLM index image. |
openshift-ci
bot
added
docs-approved
|
@mpatlasov: This pull request references STOR-1726 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 0a77e59
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.17.0-202404251439.p0.g0a77e59.assembly.stream.el9 for distgit azure-file-csi-driver-operator. |
The patch ensures that all assets in
overlays/samba/generated/standaloneare generated bygenerator. Resulting assets survive simple dynamic-provisioning test withtest/e2e/samba/samba-server.yaml