Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -nometadata to go-bindata to stop updating generated files by every build #43

Merged
merged 2 commits into from Jan 25, 2019
Merged

Add -nometadata to go-bindata to stop updating generated files by every build #43

merged 2 commits into from Jan 25, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jan 23, 2019 •
edited

This patch adds -nometadata to go-bindata option to stop updating metadata by every build.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2019
@nak3 nak3 changed the title update auto generated files Add -nometadata to go-bindata to stop updating generated files by every build Jan 23, 2019
@nak3
Copy link
Contributor Author

nak3 commented Jan 24, 2019

@wongma7 @jsafrane Could you please take a loot? This is same way with cluster-storage-operator

@nak3
Copy link
Contributor Author

nak3 commented Jan 24, 2019

/retest

@jsafrane
Copy link
Contributor

/lgtm
/approve

Thanks for the PR!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8c9046 into openshift:master Jan 25, 2019
@nak3 nak3 deleted the bindata branch January 25, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nak3 @jsafrane @openshift-ci-robot @openshift-bot @openshift-merge-robot