New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golint error #45
Fix golint error #45
Conversation
go fmt changes between 1.10 and 1.11. Last time I checked we used 1.10, so anything you push should be formatted with 1.10. |
Currently `make verify` fails due to gofmt error. This patch fixes the format.
@jsafrane Thank you! updated (and it passed the Jenkins test.) |
Ah, I misunderstood. The format error fixed in this PR causes error with go1.11, but go 1.10 misses this error. So, verify test passes either with or without this on go1.10. |
@jsafrane I'm sorry for bothering you. But I realized that this is an issue of
Can I ask you what golint version do you use? I tested on my older and newer Fedora (golint-0.0.x) but both fails. |
Interesting, I use Anyway, this looks harmless. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently golint (
./hack/verify-golint.sh
) fails due to following error:This patch fixes the error.