Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25125: Create RBAC objects first #84

Merged
merged 1 commit into from Dec 15, 2023
Merged

OCPBUGS-25125: Create RBAC objects first #84

merged 1 commit into from Dec 15, 2023

Conversation

bertinatto
Copy link
Member

Make sure SAs and Roles are created before bindings, followed by other resources like DS and Deployments.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@bertinatto bertinatto force-pushed the sort-assets branch 2 times, most recently from 9d4376e to 939f3df Compare December 12, 2023 17:31
@bertinatto bertinatto changed the title WIP: Sort assets according to their creation order preference OCPBUGS-25125: Sort assets according to their creation order preference Dec 12, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2023
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-25125, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Make sure SAs and Roles are created before bindings, followed by other resources like DS and Deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

/hold
Just testing this approach.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
@bertinatto bertinatto changed the title OCPBUGS-25125: Sort assets according to their creation order preference OCPBUGS-25125: Create RBAC objects first Dec 12, 2023
@bertinatto bertinatto marked this pull request as draft December 13, 2023 22:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
@bertinatto bertinatto closed this Dec 13, 2023
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-25125. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Make sure SAs and Roles are created before bindings, followed by other resources like DS and Deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@bertinatto bertinatto reopened this Dec 14, 2023
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-25125, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Make sure SAs and Roles are created before bindings, followed by other resources like DS and Deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto bertinatto marked this pull request as ready for review December 14, 2023 12:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
@openshift-ci openshift-ci bot requested a review from dobsonj December 14, 2023 12:02
@bertinatto
Order assets according to their creation preference
a3bb831 
Make sure Roles are created before RoleBindings, followed
by other resources like DS and Deployments.
@bertinatto
Copy link
Member Author

/test images

1 similar comment
@bertinatto
Copy link
Member Author

/test images

@jsafrane
Copy link
Contributor

I like this PR! Only if CI worked...

@bertinatto
Copy link
Member Author

/test images

@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link
Contributor

I can see in e2e logs that both StaticResourceControllers create RBAC objects first and then ServiceAccounts / Services.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@jsafrane
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2023
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-25125, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2023
@bertinatto
Copy link
Member Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 15, 2023
@bertinatto bertinatto mentioned this pull request Dec 15, 2023
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0f5ed93 into openshift:master Dec 15, 2023
9 checks passed
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-25125: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-25125 has not been moved to the MODIFIED state.

In response to this:

Make sure SAs and Roles are created before bindings, followed by other resources like DS and Deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.16.0-202312160051.p0.g0f5ed93.assembly.stream for distgit ose-aws-ebs-csi-driver-operator.
All builds following this will include this PR.

@bertinatto
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@bertinatto: new pull request created: #93

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@gnufied gnufied Awaiting requested review from gnufied

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bertinatto @openshift-ci-robot @jsafrane @openshift-bot @openshift-cherrypick-robot