RFE-3692 Upgrade to OCP 4.11 and Operator-SDK v1.25.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <mshen@redhat.com>
|
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, mjlshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE-3692
While involved in conversations for the above RFE, I noticed that this operator does not actually have the capability to support the new LoadBalancers
AllowedSourceRangesAPI which was merged in openshift/api@76624ee (after the current dependency in go.mod)What this PR does
This PR updates this codebase to align with OCP 4.11 versions (k8s v0.25.0), which implies Operator-SDK v1.25.0.
How
go get -u github.com/openshift/api@release-4.11and left a comment that we can adjust when we bump this codebase to OCP 4.12. Currently the latest Operator-SDK does not support k8s v0.26.0, which OCP 4.12 uses, which is why I am leaving this on OCP 4.11/k8s v0.25.0Next steps
If the RFE is approved, it'll be simple to add this feature to this operator - if not, we can just leave this as a dependency update :D