Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15038: Don't set ownerReference on cluster-scoped and cross-namespace objects #42

Merged
merged 1 commit into from Jun 28, 2023

Conversation

joelsmith
Copy link

@joelsmith joelsmith commented Jun 28, 2023

This is a cherry-pick of upstream PR kedacore#196 to fix https://issues.redhat.com//browse/OCPBUGS-15038

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

…amespace objects

Signed-off-by: Joel Smith <joelsmith@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-15274, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a cherry-pick of upstream PR kedacore#196

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@joelsmith
Copy link
Author

joelsmith commented Jun 28, 2023

Waiting for upstream to merge.
/hold

@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-15274, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Waiting for upstream to merge.
/hold
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@joelsmith joelsmith changed the title OCPBUGS-15274: Don't set ownerReference on cluster-scoped and cross-namespace objects OCPBUGS-15038: Don't set ownerReference on cluster-scoped and cross-namespace objects Jun 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-15038, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a cherry-pick of upstream PR kedacore#196

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelsmith
Copy link
Author

Upstream merged
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@openshift-ci-robot
Copy link

@joelsmith: This pull request references Jira Issue OCPBUGS-15038, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weinliu@redhat.com), skipping review request.

In response to this:

This is a cherry-pick of upstream PR kedacore#196 to fix https://issues.redhat.com//browse/OCPBUGS-15038

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [joelsmith,rphillips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3430156 into openshift:main Jun 28, 2023
6 checks passed
@openshift-ci-robot
Copy link

@joelsmith: Jira Issue OCPBUGS-15038: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15038 has been moved to the MODIFIED state.

In response to this:

This is a cherry-pick of upstream PR kedacore#196 to fix https://issues.redhat.com//browse/OCPBUGS-15038

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants