bug 1814547: Rebase upstream 1.18 #30
Conversation
Add damemi to approvers
…inter Switch PodsHavingTooManyRestarts params to pointer
The new PodLifeTime descheduler strategy can be used to evict pods that
were created more than the configured number of seconds ago.
In the below example pods created more than 24 hours ago will be evicted.
````
apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
strategies:
"PodLifeTime":
enabled: true
params:
maxPodLifeTimeSeconds: 86400
````
…ime-strategy Add New PodLifeTime Strategy
Update to k8s 1.18.2 dependencies
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
…avis-ci Update Travis CI build matrix with latest k8s point releases
In multi-tenant environments it is useful to know which namespace a pod was evicted from. Therefore log the namespace when evicting pods. Also, do not log a nil error when successfully evicting pods.
End users should be able to see the detailed error from the EvictPod method when it fails. Updates all strategies to log the error. The PodLifeTime strategy already logs this error.
The EvictPod function previously returned a bool and an error. The function now only returns an error. Callers can check for failure by testing if the returned error is not nil. This aligns the EvictPod function with idiomatic Go best practices. Also, the function name has been changed from EvictPod to evictPod because it is not used outside the evictions package.
…logs Add Additional Details To Pod Eviction Log Messages
This increases the specificity of the RemoveDuplicates strategy by removing pods which not only have the same owner, but who also must have the same list of container images. This also adds a parameter, `ExcludeOwnerKinds` to the RemoveDuplicates strategy which accepts a list of Kinds. If a pod has any of these Kinds as an owner, that pod is not considered for eviction.
Consider pod image in duplicates strategy
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
/retitle bug 1814547: Rebase upstream 1.18 |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@damemi: This pull request references Bugzilla bug 1814547, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@damemi: All pull requests linked via external trackers have merged: openshift/descheduler#30. Bugzilla bug 1814547 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This rebases our master to match upstream, specifically:
PodLifeTimestrategyPodsHavingTooManyRestartsparam to be a pointer\RemoveDuplicatesstrategy (https://bugzilla.redhat.com/show_bug.cgi?id=1814547)This should be the last sync with upstream we have until 1.19 (barring any critical bug fixes before then). The main reason for this sync is so that we can have our release-4.5 branch updated to 1.18 before 1.19 comes out, and the upstream descheduler repo missed this bump previously. Following this I'd like to stick to a regular sync schedule (ideally once per release)