bug 2083235: PCI address #28
Conversation
openshift-ci
bot
added
bugzilla/severity-medium
|
@bn222: This pull request references Bugzilla bug 2083235, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@bn222: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@bn222: This pull request references Bugzilla bug 2083235, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| name=$(echo $iface | jq '.name' -r) | ||
| pci_addr=$(ls -lisah /sys/class/net/$name/device | awk -F/ '{print $(NF)}') |
There was a problem hiding this comment.
We have both pci_addr and name in file /etc/sriov_config.json. Now both are hardcoded. So I don't think we need to use the name to look for the pci address. But in the future, I think it would be better to allow users to customize the NIC with either interface name or pci address.
There was a problem hiding this comment.
Do you propose that I make it so that exactly 1 of the two (name or pci_addr) is required and derive one from the other? This means that if both are specified but inconsistent, I will provide an error.
There was a problem hiding this comment.
For now, I think we can keep this file unchanged. In long term, we can think about how to allow users to specify whichever NIC they want to config with either name or PCI address. The content in /etc/sriov_config.json be rendered accordingly. This is a must-have if we're going to support DPU models other than BF2.
|
We will fix this later on |
|
@bn222: This pull request references Bugzilla bug 2083235. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Automatically derive PCI address for interface name provided in sriov_config.yaml