Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14179: Remove dependency to sriov_config.json configuration file #74

Merged
merged 3 commits into from Jun 5, 2023
Merged

OCPBUGS-14179: Remove dependency to sriov_config.json configuration file #74

merged 3 commits into from Jun 5, 2023

Conversation

wizhaoredhat
Copy link
Contributor

@wizhaoredhat wizhaoredhat commented May 26, 2023 •
edited

Since DPUs are not actually servers. The DPU will be vendor specific. Thus assumptions can be made once the DPU vendor and device has been identified. For now, we will add NVIDIA BF DPU support.

Signed-off-by: William Zhao wizhao@redhat.com

@wizhaoredhat
Cleanup Udev and script.
a73a70f 
Signed-off-by: William Zhao <wizhao@redhat.com>
@wizhaoredhat
Copy link
Contributor Author

/cc @SalDaniele
/cc @bn222
/cc @zshi-redhat

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wizhaoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@wizhaoredhat wizhaoredhat changed the title Remove dependency to sriov_config.json configuration file OCPBUGS-14179: Remove dependency to sriov_config.json configuration file May 27, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 27, 2023
@openshift-ci-robot
Copy link

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-14179, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since DPUs are not actually servers. The DPU will be vendor specific. Thus assumptions can be made once the DPU vendor and device has been identified. For now, we will add NVIDIA BF2 DPU support.

Signed-off-by: William Zhao wizhao@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 27, 2023
@wizhaoredhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2023
@openshift-ci-robot
Copy link

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-14179, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yingwang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wizhaoredhat
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-14179, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yingwang@redhat.com), skipping review request.

In response to this:

Since DPUs are not actually servers. The DPU will be vendor specific. Thus assumptions can be made once the DPU vendor and device has been identified. For now, we will add NVIDIA BF DPU support.

Signed-off-by: William Zhao wizhao@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wizhaoredhat
Copy link
Contributor Author

/hold
Looking into improvements.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023
@wizhaoredhat
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023
@wizhaoredhat
Copy link
Contributor Author

@pliurh PTAL

@wizhaoredhat
Copy link
Contributor Author

@pliurh Do you know why we have to run /usr/local/bin/configure-ovs.sh OpenShiftSDN on every boot in ovs-reconfig.sh?

@pliurh
Copy link
Contributor

pliurh commented May 30, 2023

/usr/local/bin/configure-ovs.sh OpenShiftSDN will only be executed when the br-ex is not using switchdev port as the uplink port. So it shall only run once. It is to remove the existing br-ex then we can recreate the br-ex with switchdev port.

@wizhaoredhat wizhaoredhat force-pushed the improve_machine_config branch 2 times, most recently from 5c2b0c0 to 765b199 Compare May 31, 2023 18:53
@wizhaoredhat
Remove dependency to configuration file.
691af7b 
Since DPUs are not actually servers. The DPU will be vendor specific.
Thus assumptions can be made once the DPU vendor and device has been
identified. For now, we will add NVIDIA BF2 DPU support.

Signed-off-by: William Zhao <wizhao@redhat.com>
@wizhaoredhat
Remove ovs-reconfig.sh since ovs-configuration is emphemeral
7319059 
Please refer to machine-config-operator with the commit hash:
ed86f924b01499175181999498271c0395b5a1e8 for the change to
emphemeral ovs-configuration.

When running ovs-add-pf.sh after ovs-configuration and checking
the ports on br-ex, yields the following:

ovs-add-pf.sh[4088]:     Bridge br-ex
ovs-add-pf.sh[4088]:         Port br-ex
ovs-add-pf.sh[4088]:             Interface br-ex
ovs-add-pf.sh[4088]:                 type: internal
ovs-add-pf.sh[4088]:         Port p0
ovs-add-pf.sh[4088]:             Interface p0
ovs-add-pf.sh[4088]:                 type: system

This shows that only the uplink port was added to br-ex after
ovs-configuration.

Signed-off-by: William Zhao <wizhao@redhat.com>
@pliurh
Copy link
Contributor

pliurh commented Jun 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

@wizhaoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4981303 into openshift:master Jun 5, 2023
4 checks passed
@openshift-ci-robot
Copy link

@wizhaoredhat: Jira Issue OCPBUGS-14179: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14179 has been moved to the MODIFIED state.

In response to this:

Since DPUs are not actually servers. The DPU will be vendor specific. Thus assumptions can be made once the DPU vendor and device has been identified. For now, we will add NVIDIA BF DPU support.

Signed-off-by: William Zhao wizhao@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh pliurh left review comments

@bn222 bn222 Awaiting requested review from bn222

@SalDaniele SalDaniele Awaiting requested review from SalDaniele

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@pliurh pliurh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wizhaoredhat @openshift-ci-robot @pliurh @bn222 @openshift-merge-robot