Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testability #61

Merged
merged 2 commits into from
May 16, 2024
Merged

Testability #61

merged 2 commits into from
May 16, 2024

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented May 2, 2024

Use a kind cluster instead of only a control plane for integration tests. This reduces the run time of tests from 42 seconds to 2 seconds on my system for subsequent runs since the cluster is not destroyed.

Copy link

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@bn222
Copy link
Contributor Author

bn222 commented May 2, 2024

/retest

@bn222 bn222 force-pushed the testability branch 9 times, most recently from 080e81d to 18c0df2 Compare May 3, 2024 10:01
@bn222
Copy link
Contributor Author

bn222 commented May 3, 2024

/retest

@bn222
Copy link
Contributor Author

bn222 commented May 3, 2024

/pj-rehearse

@bn222
Copy link
Contributor Author

bn222 commented May 3, 2024

/retest

@bn222 bn222 force-pushed the testability branch 4 times, most recently from 8af331c to b6ddf55 Compare May 3, 2024 18:28
@bn222
Copy link
Contributor Author

bn222 commented May 5, 2024

/retest

4 similar comments
@bn222
Copy link
Contributor Author

bn222 commented May 15, 2024

/retest

@bn222
Copy link
Contributor Author

bn222 commented May 15, 2024

/retest

@bn222
Copy link
Contributor Author

bn222 commented May 15, 2024

/retest

@bn222
Copy link
Contributor Author

bn222 commented May 15, 2024

/retest

@bn222
Copy link
Contributor Author

bn222 commented May 16, 2024

/retest ci/prow/e2e-dpu-operator-tests

Copy link

openshift-ci bot commented May 16, 2024

@bn222: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-dpu-operator-tests
  • /test images
  • /test make-test

Use /test all to run all jobs.

In response to this:

/retest ci/prow/e2e-dpu-operator-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bn222
Copy link
Contributor Author

bn222 commented May 16, 2024

/override ci/prow/e2e-dpu-operator-tests

1 similar comment
@bn222
Copy link
Contributor Author

bn222 commented May 16, 2024

/override ci/prow/e2e-dpu-operator-tests

Copy link

openshift-ci bot commented May 16, 2024

@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests

In response to this:

/override ci/prow/e2e-dpu-operator-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 16, 2024

@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests

In response to this:

/override ci/prow/e2e-dpu-operator-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bn222 added 2 commits May 16, 2024 18:37
This reduces subsequent test runs from 42 seconds to 2 seconds on
my system when using `make fast-test`. Both `make test` use the
same code. Howevere, the `fast-test` version doesn't tear down the
kind cluster. This allows for fast iteration during development.

Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
@wizhaoredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 428b550 and 2 for PR HEAD af6d6b2 in total

Copy link

openshift-ci bot commented May 16, 2024

@bn222: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit b6ddf55 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor Author

bn222 commented May 16, 2024

/override ci/prow/e2e-dpu-operator-tests

Copy link

openshift-ci bot commented May 16, 2024

@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests

In response to this:

/override ci/prow/e2e-dpu-operator-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ea1776b into openshift:main May 16, 2024
5 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build dpu-operator-container-v4.17.0-202405162013.p0.gea1776b.assembly.stream.el9 for distgit dpu-operator.
All builds following this will include this PR.

@bn222 bn222 deleted the testability branch May 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants